X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C88F93.78CB8C88@onstor-exch02.onstor.net>; Wed, 26 Mar 2008 15:48:12 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review
Date: Wed, 26 Mar 2008 15:48:12 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E091AA67A@onstor-exch02.onstor.net>
In-Reply-To: <20080326154626.1ec3a776@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review
Thread-Index: AciPkzk+kWxXdoqLQPKtckdZH657pQAADmGQ
References: <BB375AF679D4A34E9CA8DFA650E2B04E090EB0F5@onstor-exch02.onstor.net> <20080326154626.1ec3a776@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

=3D=3D=3D=3D //depot/dev/linux/src/dmalloc-5.5.1/debian/rules#1 -
/m/dev/linux/src/dmalloc-5.5.1/debian/rules =3D=3D=3D=3D
***************
*** 13,19 ****
  DEB_HOST_GNU_TYPE   ?=3D $(shell dpkg-architecture =
-qDEB_HOST_GNU_TYPE)
  DEB_BUILD_GNU_TYPE  ?=3D $(shell dpkg-architecture =
-qDEB_BUILD_GNU_TYPE)
 =20
! CFLAGS =3D -Wall -g
 =20
  ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
        CFLAGS +=3D -O0
--- 13,19 ----
  DEB_HOST_GNU_TYPE   ?=3D $(shell dpkg-architecture =
-qDEB_HOST_GNU_TYPE)
  DEB_BUILD_GNU_TYPE  ?=3D $(shell dpkg-architecture =
-qDEB_BUILD_GNU_TYPE)
 =20
! CFLAGS =3D -Wall -g -fno-reorder-blocks
 =20
  ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
        CFLAGS +=3D -O0
***************
*** 86,92 ****
        dh_installinfo
        dh_installman
        dh_link
-       dh_strip
        dh_compress -Xusr/share/doc/libdmalloc-dev/examples
        dh_fixperms
        dh_makeshlibs
--- 86,91 ----

>-----Original Message-----
>From: Andy Sharp
>Sent: Wednesday, March 26, 2008 3:46 PM
>To: Maxim Kozlovsky
>Subject: Re: please review
>
>On Wed, 26 Mar 2008 15:16:04 -0700 "Maxim Kozlovsky"
><maxim.kozlovsky@onstor.com> wrote:
>
>> Change 28520 by maximk@maximk-6 on 2008/03/26 15:15:44 *pending*
>>
>>         Don't strip the library otherwise a core file may be
>> undebuggable.
>>            Reviewed by andys.
>>
>> Affected files ...
>>
>> ... //depot/dev/linux/src/dmalloc-5.5.1/debian/rules#1 edit
>
>
>$ review-new-script.sh 28520
>Client 'maximk-6' can only be used from host 'maxk-linux'.
>
>You need to remove the 'Host' tag from the client spec.
>
>If this is one liner-ish, just paste the diff into the email.
