X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C88F71.79A42418@onstor-exch02.onstor.net>; Wed, 26 Mar 2008 11:44:51 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C88F71.79A42418"
Content-class: urn:content-classes:message
Subject: Please review code change for TED 22865 SC Port not correctly reported as down - Customer - ZDF - case 7494
Date: Wed, 26 Mar 2008 11:44:50 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E090EAF1E@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review code change for TED 22865 SC Port not correctly reported as down - Customer - ZDF - case 7494
Thread-Index: AciPcXjUpWMHZzLbQFmvyoU2e0YKJg==
From: "Ed Kwan" <ed.kwan@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C88F71.79A42418
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

[edk@edk-linux nfx-tree]$ p4 describe 28517
Change 28517 by edk@edk-dev on 2008/03/26 11:40:56 *pending*

        Changes for TED 22865.  Do not always set the IPM_AUXIF_RUNNING
        flag.  Check the IFF_RUNNING interface flag first.
        Awaiting review by AndyS.

Affected files ...

... //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c#13 edit
... //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-openbsd.c#4 edit


My test case (Operation State should be DOWN when the cable is removed):

With both SC ports in use:

eng93 diag> int show int
Interface  Table
-------------------------------------------------------------
Interface     Admin.     Operation  Mac Address         LPORT
-------------------------------------------------------------
sc1           UP         UP         00:07:34:02:08:00   sc1
sc2           UP         UP         00:07:34:02:08:01   sc2
eng93 diag> int show int -a sc2
Interface       :  sc2
Admin. State    :  UP
Operat State    :  UP
Mtu Size        :  1518
Mac Address     :  00:07:34:02:08:01

Unplugg the cabel to sc2:

eng93 diag> int show int
Interface  Table
-------------------------------------------------------------
Interface     Admin.     Operation  Mac Address         LPORT
-------------------------------------------------------------
sc1           UP         UP         00:07:34:02:08:00   sc1
sc2           UP         DOWN       00:07:34:02:08:01   sc2
eng93 diag> int show int -a sc2
Interface       :  sc2
Admin. State    :  UP
Operat State    :  DOWN
Mtu Size        :  1518
Mac Address     :  00:07:34:02:08:01


------_=_NextPart_001_01C88F71.79A42418
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Dus-ascii">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>Please review code change for TED 22865 SC Port not correctly =
reported as down - Customer - ZDF - case 7494</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/rtf format -->

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D2 FACE=3D"Arial">[edk@edk-linux nfx-tree]$ p4 describe =
28517</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">Change =
28517 by edk@edk-dev on 2008/03/26 11:40:56 *pending*</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Changes for =
TED 22865.&nbsp; Do not always set the =
IPM_AUXIF_RUNNING</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; flag.&nbsp; =
Check the IFF_RUNNING interface flag first.</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Awaiting =
review by AndyS.</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">Affected =
files ...</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">... =
//depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c#13 =
edit</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">... =
//depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-openbsd.c#4 =
edit</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">My test =
case</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D2 FACE=3D"Arial"> (Operation State should be DOWN when =
t</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D2 FACE=3D"Arial">he cable is removed)</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">:</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D2 FACE=3D"Arial">With both SC ports in use:</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D1 FACE=3D"CourierPS">eng93 diag&gt; int show =
int</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Interface&nbsp; Table</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">------------------------------------------------------=
-------</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Interface&nbsp;&nbsp;&nbsp;&nbsp; =
Admin.&nbsp;&nbsp;&nbsp;&nbsp; Operation&nbsp; Mac =
Address&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
LPORT</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">------------------------------------------------------=
-------</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">sc1&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp; UP&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
UP&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
00:07:34:02:08:00&nbsp;&nbsp; sc1</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">sc2&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp; UP&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
UP&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
00:07:34:02:08:01&nbsp;&nbsp; sc2</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">eng93 diag&gt; int show int -a sc2</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Interface&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; :&nbsp; =
sc2</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Admin. State&nbsp;&nbsp;&nbsp; :&nbsp; =
UP</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Operat State&nbsp;&nbsp;&nbsp; :&nbsp; =
UP</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 FACE=3D"CourierPS">Mtu =
Size&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; :&nbsp; =
1518</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 FACE=3D"CourierPS">Mac =
Address&nbsp;&nbsp;&nbsp;&nbsp; :&nbsp; =
00:07:34:02:08:01</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">Unplugg =
the cabel to sc2:</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D1 FACE=3D"CourierPS">eng93 diag&gt; int show =
int</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Interface&nbsp; Table</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">------------------------------------------------------=
-------</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Interface&nbsp;&nbsp;&nbsp;&nbsp; =
Admin.&nbsp;&nbsp;&nbsp;&nbsp; Operation&nbsp; Mac =
Address&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
LPORT</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">------------------------------------------------------=
-------</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">sc1&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp; UP&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
UP&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
00:07:34:02:08:00&nbsp;&nbsp; sc1</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">sc2&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp; UP&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
DOWN&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 00:07:34:02:08:01&nbsp;&nbsp; =
sc2</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">eng93 diag&gt; int show int -a sc2</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Interface&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; :&nbsp; =
sc2</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Admin. State&nbsp;&nbsp;&nbsp; :&nbsp; =
UP</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 =
FACE=3D"CourierPS">Operat State&nbsp;&nbsp;&nbsp; :&nbsp; =
DOWN</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 FACE=3D"CourierPS">Mtu =
Size&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; :&nbsp; =
1518</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D1 FACE=3D"CourierPS">Mac =
Address&nbsp;&nbsp;&nbsp;&nbsp; :&nbsp; =
00:07:34:02:08:01</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

</BODY>
</HTML>
------_=_NextPart_001_01C88F71.79A42418--
