X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C88915.73428BD6@onstor-exch02.onstor.net>; Tue, 18 Mar 2008 09:31:00 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: additional item for review list
Date: Tue, 18 Mar 2008 09:30:59 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E08F02401@onstor-exch02.onstor.net>
In-Reply-To: <20080317141201.120331d8@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: additional item for review list
Thread-Index: AciIc4u35QLcx3UNQz+MWC0v5FdbnwAocycg
From: "Paul Hammer" <paul.hammer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Hey Andy,

Good point. I will add it to the procedure. I should be able to send the
procedure out for review in the next few days.

Thanks,

-Paul

-----Original Message-----
From: Andy Sharp=20
Sent: 2008-03-17 14:12
To: Paul Hammer
Subject: additional item for review list

Hi Paul,

This is from my notes from your tech-talk last Thursday.  I don't have
a copy of the slides, but there was one slide with a number of
code-review-checkin guidelines or conventions.

There is an additional item that needs to be added to the things under
code-review-checkin list, and that is checkin comment. The checkin
comment also must be reviewed at the time of code review.

Currently when someone sends me a review request, I ask them to put it
into a separate changelist, where I can review both the changes and the
checkin comment.

Cheers,

a
