X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C88468.69BDB344@onstor-exch02.onstor.net>; Wed, 12 Mar 2008 10:42:16 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C88468.69BDB344"
References: <WEBMAILg01aups8u6jV00000223@mail.onstor.com><BB375AF679D4A34E9CA8DFA650E2B04E08D2A3C8@onstor-exch02.onstor.net> <20080312094809.278d2e7e@ripper.onstor.net> <BB375AF679D4A34E9CA8DFA650E2B04E08D2A479@onstor-exch02.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 28304 for review
Date: Wed, 12 Mar 2008 10:40:39 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E042F0100@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 28304 for review
Thread-Index: AciEYNyFZ8+46e19RbSNwGAQfjmokQAAGVeAAAG7hBA=
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>
Cc: "Tim Gardner" <tim.gardner@onstor.com>,
	"Mike Lee" <mike.lee@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C88468.69BDB344
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Just specutlating.. but what if there is heap corruption while writing =
the core file? With this setting libc doesn't fault and finishes writing =
the core file successfully.


-----Original Message-----
From: Maxim Kozlovsky
Sent: Wed 3/12/2008 9:52 AM
To: Andy Sharp
Cc: Larry Scheer; Tim Gardner; Mike Lee
Subject: RE: PERFORCE change 28304 for review
=20

Why would the segfault within the C library produce a corrupt core file? =


>-----Original Message-----
>From: Andy Sharp
>Sent: Wednesday, March 12, 2008 9:48 AM
>To: Maxim Kozlovsky
>Cc: Larry Scheer; Tim Gardner; Mike Lee
>Subject: Re: PERFORCE change 28304 for review
>
>On Wed, 12 Mar 2008 08:49:09 -0700 "Maxim Kozlovsky"
><maxim.kozlovsky@onstor.com> wrote:
>
>> Huh?
>>
>> Man malloc:
>> "If MALLOC_CHECK_ is set to 0, any detected heap corruption is
>> silently ignored"
>>
>> How does that enable us to collect more meaningful core files?
>
>Man pages aren't code.  Feel free to look at the code and figure out
>why.  Without it, certain types of segfaults within the C library leave
>us with a corrupt core file.
>
>
>
>> >-----Original Message-----
>> >From: Larry Scheer
>> >Sent: Tuesday, March 11, 2008 9:55 PM
>> >To: Amit Bothra; Andy Sharp; Brian DeForest; Charissa Willard; Chris
>> >Vandever; Deepak Veliath; Eric Barrett; Ian Brown; Jobi Ariyamannil;
>> >Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim Kozlovsky; Narain
>> >Ramadass; Sandrine Boulanger; Svati Chandra; Tim Gardner
>> >Subject: PERFORCE change 28304 for review
>> >
>> >Change 28304 by larrys@larrys-r14-dmip on 2008/03/11 21:50:40
>> >
>> >	 TED00022699 Cougar - vsd core  pm_sig_handler
>> >
>> >	 Creating /etc/default/onstor in Linux root filesystem.
>> >	 Setting MALLOC_CHECK_=3D0 so we can collect more meaningful
>> >	 core files.
>> >
>> >	 Updated linux/rootfs/Makefile to
>> >	install /etc/default/onstor. Reviewed by: TimG
>> >
>> >Affected files ...
>> >
>> >... //depot/dev/linux/rootfs/Makefile#24 edit
>> >... //depot/dev/linux/rootfs/etc/default/onstor#1 add
>> >
>> >
>> >http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/28304?ac=3D10


------_=_NextPart_001_01C88468.69BDB344
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>RE: PERFORCE change 28304 for review</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>Just specutlating.. but what if there is heap =
corruption while writing the core file? With this setting libc doesn't =
fault and finishes writing the core file successfully.<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: Maxim Kozlovsky<BR>
Sent: Wed 3/12/2008 9:52 AM<BR>
To: Andy Sharp<BR>
Cc: Larry Scheer; Tim Gardner; Mike Lee<BR>
Subject: RE: PERFORCE change 28304 for review<BR>
<BR>
<BR>
Why would the segfault within the C library produce a corrupt core =
file?<BR>
<BR>
&gt;-----Original Message-----<BR>
&gt;From: Andy Sharp<BR>
&gt;Sent: Wednesday, March 12, 2008 9:48 AM<BR>
&gt;To: Maxim Kozlovsky<BR>
&gt;Cc: Larry Scheer; Tim Gardner; Mike Lee<BR>
&gt;Subject: Re: PERFORCE change 28304 for review<BR>
&gt;<BR>
&gt;On Wed, 12 Mar 2008 08:49:09 -0700 &quot;Maxim Kozlovsky&quot;<BR>
&gt;&lt;maxim.kozlovsky@onstor.com&gt; wrote:<BR>
&gt;<BR>
&gt;&gt; Huh?<BR>
&gt;&gt;<BR>
&gt;&gt; Man malloc:<BR>
&gt;&gt; &quot;If MALLOC_CHECK_ is set to 0, any detected heap =
corruption is<BR>
&gt;&gt; silently ignored&quot;<BR>
&gt;&gt;<BR>
&gt;&gt; How does that enable us to collect more meaningful core =
files?<BR>
&gt;<BR>
&gt;Man pages aren't code.&nbsp; Feel free to look at the code and =
figure out<BR>
&gt;why.&nbsp; Without it, certain types of segfaults within the C =
library leave<BR>
&gt;us with a corrupt core file.<BR>
&gt;<BR>
&gt;<BR>
&gt;<BR>
&gt;&gt; &gt;-----Original Message-----<BR>
&gt;&gt; &gt;From: Larry Scheer<BR>
&gt;&gt; &gt;Sent: Tuesday, March 11, 2008 9:55 PM<BR>
&gt;&gt; &gt;To: Amit Bothra; Andy Sharp; Brian DeForest; Charissa =
Willard; Chris<BR>
&gt;&gt; &gt;Vandever; Deepak Veliath; Eric Barrett; Ian Brown; Jobi =
Ariyamannil;<BR>
&gt;&gt; &gt;Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim =
Kozlovsky; Narain<BR>
&gt;&gt; &gt;Ramadass; Sandrine Boulanger; Svati Chandra; Tim =
Gardner<BR>
&gt;&gt; &gt;Subject: PERFORCE change 28304 for review<BR>
&gt;&gt; &gt;<BR>
&gt;&gt; &gt;Change 28304 by larrys@larrys-r14-dmip on 2008/03/11 =
21:50:40<BR>
&gt;&gt; &gt;<BR>
&gt;&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; TED00022699 Cougar - vsd =
core&nbsp; pm_sig_handler<BR>
&gt;&gt; &gt;<BR>
&gt;&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; Creating /etc/default/onstor in =
Linux root filesystem.<BR>
&gt;&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; Setting MALLOC_CHECK_=3D0 so we =
can collect more meaningful<BR>
&gt;&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; core files.<BR>
&gt;&gt; &gt;<BR>
&gt;&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; Updated linux/rootfs/Makefile =
to<BR>
&gt;&gt; &gt;&nbsp;&nbsp;&nbsp; install /etc/default/onstor. Reviewed =
by: TimG<BR>
&gt;&gt; &gt;<BR>
&gt;&gt; &gt;Affected files ...<BR>
&gt;&gt; &gt;<BR>
&gt;&gt; &gt;... //depot/dev/linux/rootfs/Makefile#24 edit<BR>
&gt;&gt; &gt;... //depot/dev/linux/rootfs/etc/default/onstor#1 add<BR>
&gt;&gt; &gt;<BR>
&gt;&gt; &gt;<BR>
&gt;&gt; &gt;<A =
HREF=3D"http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/28304?ac=3D10">h=
ttp://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/28304?ac=3D10</A><BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C88468.69BDB344--
