X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C88470.D2FEFDEC@onstor-exch02.onstor.net>; Wed, 12 Mar 2008 11:42:29 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Prom upgrade runtime changes
Date: Wed, 12 Mar 2008 11:42:28 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E08D2A5BD@onstor-exch02.onstor.net>
In-Reply-To: <20080311195558.6a727e81@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Prom upgrade runtime changes
Thread-Index: AciD7JlvnHp/v4+WQk6e564jCkZViQAhAj2g
References: <BB375AF679D4A34E9CA8DFA650E2B04E08D29F3A@onstor-exch02.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E056C9468@onstor-exch02.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E08D2A198@onstor-exch02.onstor.net><20080311181729.64c51a74@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E08D2A210@onstor-exch02.onstor.net> <20080311195558.6a727e81@ripper.onstor.net>
From: "Warren Gale" <warren.gale@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Ok.  I think I got all the changes in.
Just finish re-test.  Looks good..
Mind looking at it again?

Thanks,
Warren

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, March 11, 2008 7:56 PM
To: Warren Gale
Subject: Re: Prom upgrade runtime changes

On Tue, 11 Mar 2008 19:07:19 -0700 "Warren Gale"
<warren.gale@onstor.com> wrote:

>=20
> Ok, Cool... Thanks.. I'll start working on it..
> Please see below ..  <wg>  :)
>=20
>=20
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Tuesday, March 11, 2008 6:17 PM
> To: Warren Gale
> Cc: Larry Scheer
> Subject: Re: Prom upgrade runtime changes
>=20
> My comments:
>=20
> nfx-tree/code/sm-prom-upgrade/from-upgrade.c
>=20
> ---------
> <wg>  actually I don't know who did it, I just get to update it...
>       I agree that it's ugly, but it is used for Bobcat and Cheetah=20
>       as well.  Since the partitions of the PROM have changed for=20
>       Cougar, and their sizes, this seemed to work best without having
>       to make lots of changes other code

You did it.  I'm talking about your changes only here.  You should do
it correctly in prom-part-api.h w.r.t my comment for that file.

> --------- =20
>=20
>      this is your code, but this is damn ugly.  shouldn't you set
>      PART_DESC_SIBYTE_FP_LAYOUT to be the right value for cougar
>      instead of adding yet another nasty ifdef?  i leave it up to you.
>      do the right thing or your fired.  i kid.
>=20
>=20
> nfx-tree/code/sm-prom-upgrade/prom-part-api.h
>=20
>=20
>      again, i would do a big ifdef COUGAR define these two sibyte
>      macros, or define them the previous way.

Uh, well, that comment could be a little clearer I guess.

> nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c
>=20
>=20
>      looks ok.  if you can stand variables named 'puout'
>=20
> ---------
> <wg>
>     Ok Changed  ifdefs here on 503 and friend.. (Like that one)..
>     Changed 625 and got rid of 1023... Sorry I missed that one.
> ---------

That's why we're here.


>      line 503 and friend.  these ifdef COUGARs should have an else
>      for the other code that doesn't apply when it's a cougar.
>=20
>      line 625 don't do this.  put whole, complete assignments inside
>      each ifdef block.
>=20
>      line 1023 is bogus
>=20
>      rest is ok.  some formatting changes a welcome refreshment.
>=20
> nfx-tree/code/ssc-nfxsh/menu.c
>=20
>=20
>      looks good
>=20
>=20
> nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c
>=20
> -------------
> <wg>
> http://wiki.onstor.net/wiki/Onstor_Coding_Style_Guide
> Whitespace and formatting:
> I guess number 1 and number 2 is just plain wrong.

Number 1 is wrong, #2 is right.  Set shift width and tab stop to 4.

Stupid stinkin' Winblows programmers got to this wiki.  I'll fix that.
Sorry you got bit.

> Ok, I can put it back. Your call.. :)
> (That's what I get for trying to take ownership of a
> file :(  stung :) ) -----------

Sorry.  Big whitespace changes make it difficult to track changes.
Instead, if you want to format the file in your own way, do a separate,
whitespace/style only checkin, that way someone else, or you even, can
easily ignore that change just by looking at the comment.  If you want
to do that, then feel free to use me as the reviewer.  I'll take the
time.

>      holy cauliflower! what's with all the unneccessary whitespace
>      changes?  can you please redo this, and delete all the
> unnecessary whitespace changes so I can see the substantive changes?
> if there is some trailing whitespace that needs cleaning, you can do
> bits of that, but not the whole dang file.  And especially since you
>      went the wrong way: converting tabs to spaces.  my lord.
>=20
>=20
>=20
>=20
>=20
> On Tue, 11 Mar 2008 17:51:59 -0700 "Warren Gale"
> <warren.gale@onstor.com> wrote:
>=20
> > Larry,
> >=20
> > =20
> >=20
> >     Ok, Cool.  I changed all the strcpy  's  to   strncpy  's  in
> > this file.
> >=20
> >     It tested ok also.
> >=20
> > Thanks,
> >=20
> > Warren
> >=20
> > =20
> >=20
> > Andy,
> >=20
> >    If you ignore white space on this file there are very few
> > changes..
> >=20
> >  Ie tkdiff -db =20
> >=20
> > =20
> >=20
> > Thanks,
> >=20
> > Warren
> >=20
> > ________________________________
> >=20
> > From: Larry Scheer=20
> > Sent: Tuesday, March 11, 2008 5:15 PM
> > To: Warren Gale
> > Cc: Andy Sharp
> > Subject: RE: Prom upgrade runtime changes
> >=20
> > =20
> >=20
> > nfx-tree/code/sm-prom-upgrade/from-upgrade.c
> >=20
> > =20
> >=20
> >      looks good
> >=20
> > =20
> >=20
> > nfx-tree/code/sm-prom-upgrade/prom-part-api.h
> >=20
> > =20
> >=20
> >      looks good
> >=20
> > =20
> >=20
> > nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c
> >=20
> > =20
> >=20
> >      line 127 you might get future grief for using strcpy versus
> >=20
> >      strncpy.  Perhaps you should change this to keep Coverity from
> >=20
> >      flagging it as a defect and then you won't have to worry about
> >=20
> >      some HCL guy bollixing up your code.
> >=20
> > =20
> >=20
> > nfx-tree/code/ssc-nfxsh/menu.c
> >=20
> > =20
> >=20
> >      looks good
> >=20
> > =20
> >=20
> > nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c
> >=20
> > =20
> >=20
> >      Not reviewed. Check with Andy
> >=20
> > =20
> >=20
> > ________________________________
> >=20
> > From: Warren Gale=20
> > Sent: Tuesday, March 11, 2008 11:59 AM
> > To: Larry Scheer
> > Subject: FW: Prom upgrade runtime changes
> >=20
> > =20
> >=20
> > Larry,
> >=20
> >   I'd like to get this in on the next build.
> >=20
> > I sent this to Andy S.   Thought I'd also send you a copy.
> >=20
> > =20
> >=20
> > Thanks, and for the p4 help too.
> >=20
> > Warren
> >=20
> > =20
> >=20
> > ________________________________
> >=20
> > From: Warren Gale=20
> > Sent: Tuesday, March 11, 2008 11:38 AM
> > To: Andy Sharp
> > Subject: Prom upgrade runtime changes
> >=20
> > =20
> >=20
> > Andy,
> >=20
> >   Please review.
> > Thanks,
> >=20
> > Warren
> >=20
> > =20
> >=20
> > Change 28170 by warreng@warreng-cougar on 2008/03/04 18:05:31
> > *pending*
> >=20
> > =20
> >=20
> >         Fix to /onstor/bin/prom-upgrade command.
> >=20
> >         Fix was to get prom-upgrade app Id and use it as 1st param
> > to sendAgileMsg.
> >=20
> >         Add support for cougar prom partitions.
> >=20
> >         fix nfxsh prom upgrade command.  (for Cougar, only FP and
> > TXRX are upgraded)
> >=20
> >         fix to nfxsh prom upgrade files command.
> >=20
> >         Now able to get a tar.gz file from upgrade server.
> >=20
> > =20
> >=20
> > Affected files ...
> >=20
> > =20
> >=20
> > ... //depot/dev/nfx-tree/code/sm-prom-upgrade/from-upgrade.c#2 edit
> >=20
> > ... //depot/dev/nfx-tree/code/sm-prom-upgrade/prom-part-api.h#1 edit
> >=20
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#11 edit
> >=20
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#10 edit
> >=20
> > ... //depot/dev/nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c#5 edit
> >=20
> > =20
> >=20
