X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C880C1.B3BA6A80@onstor-exch02.onstor.net>; Fri, 7 Mar 2008 19:11:21 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: code review-lette
Date: Fri, 7 Mar 2008 19:11:21 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E08C0F531@onstor-exch02.onstor.net>
In-Reply-To: <20080307175149.38e2a6ce@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: code review-lette
Thread-Index: AciAvvxK0cnQU1rKRBSbHRl5ReRJdAAAqVJg
From: "Jobi Ariyamannil" <jobi.ariyamannil@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Looks ok to me.

-----Original Message-----
From: Andy Sharp=20
Sent: Friday, March 07, 2008 5:52 PM
To: Jobi Ariyamannil
Subject: code review-lette

Hi J-man,

Can you look at this diff and tell me if it's all right?  I am
completely unfamiliar with this macro or this code.  Kumar says the
original code only works if the compiler 8-byte aligns the buffer
'entry', and it doesn't on Linux.  He says the second version of the
code fixes the problem.

Thanks,

a


diff nfx-tree/code/sm-file/filesh.c
/homes/kumarv/work/dev/nfx-tree/code/sm-file/filesh.c
940,941c940,942
<         loop +=3D ((uint32)FS_READDIRENH_NEXT_ENTRY_PTR(entry,
entry->nameLen, entry->aliasLen) -
<                  (uint32)entry);
---
>         /* Calculate the offset to next directory entry record in the
buffer.
>          */
>         loop +=3D ((uint32)FS_READDIRENH_NEXT_ENTRY_PTR(0,
entry->nameLen, entry->aliasLen));

