X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8808C.251AB20C@onstor-exch02.onstor.net>; Fri, 7 Mar 2008 12:47:58 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28211
Date: Fri, 7 Mar 2008 12:47:58 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9446@onstor-exch02.onstor.net>
In-Reply-To: <20080306203949.4d39cec6@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28211
Thread-Index: AciADUeFAn6lQCpuQx+0W1p1jL4LyQAfsHUw
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

nfx-tree/code/ssc-genlib/fs-openbsd.c

     looks good

nfx-tree/code/ssc-initial-config/initial-config.c

     Lines 1872 - 1880 Looks like these should be moved below line 1894.
     Line 1889 - 1890 Looks like these should be moved above line 1895.
     After moving these lines around the order of make writable and
     mount secondary remain the same as the original version. If your
     intent was to swap the order then more window dressing is needed.

nfx-tree/code/ssc-zebra/fs-vector.c

     Line 157, is 79 characters large enough for the device and mount
     dir? Maybe... But what if there is a long NFS path in an NFS
     mount? This might be fine for a while... dunno.


-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, March 06, 2008 8:40 PM
To: Larry Scheer
Subject: please review 28211

Change 28211 by andys@ripper on 2008/03/06 15:39:52 *pending*

        TED00022323 - FTI Doesn't copy config from secondary flash
       =20
        FTI code not properly remounting root read-write, so
        config files not copied.
       =20
        Wrong file included in ssc-genlib/fs-linux.c causing
        Linux config files to be copied on both Linux and
        OpenBSD systems.
       =20
        Found and fixed potential overflow problem with fscanf
        and fgets in make_secondary_fstabs which was causing
        core dumps when fstab had unusual lines.
       =20
        reviewed by

Affected files ...

... //depot/dev/nfx-tree/code/ssc-genlib/fs-openbsd.c#5 edit
... //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.c#5 edit
... //depot/dev/nfx-tree/code/ssc-zebra/fs-vector.c#2 edit

