X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C87FEE.3513BB50@onstor-exch02.onstor.net>; Thu, 6 Mar 2008 17:57:24 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28118
Date: Thu, 6 Mar 2008 17:57:24 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E03B1C0D6@onstor-exch02.onstor.net>
In-Reply-To: <20080306161644.0b473d44@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28118
Thread-Index: Ach/6Ici+PLst3BhRkWt3WV9waYV+QABZYpA
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

I'm running #16.

//depot/dev/nfx-tree/code/ssc-support/emrscron
... #16 change 28163 edit on 2008/03/04 by ianb@ianb-dev-1 (xtext) 'I
wrote a test 'emrscron.t' tha'


-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, March 06, 2008 4:17 PM
To: Rendell Fong
Subject: Re: please review 28118

Check what version of emrscron you're running ~:^)

On Thu, 6 Mar 2008 15:49:04 -0800 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Ok, all I know is that my crontab file is getting really huge with 2
> extra sets of header comment lines per reboot.
>=20
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Thursday, March 06, 2008 3:36 PM
> To: Rendell Fong
> Subject: Re: please review 28118
>=20
> On Thu, 6 Mar 2008 11:09:10 -0800 "Rendell Fong"
> <rendell.fong@onstor.com> wrote:
>=20
> > > Are you saying SAVELINE should be 3 for both OpenBSD and Linux?
> >=20
> > Yes, I believe so.  The first 3 lines need to be skipped in both
> > cases. Otherwise, the lines get repeated each time the crontab file
> > is updated.
>=20
> I went over this with Ian, he convinced me it's correct as is.  The
> crontab -l command in Linux purposely does not output the 3 header
> lines, so they don't need to be skipped.
>=20
> > -----Original Message-----
> > From: Andy Sharp=20
> > Sent: Thursday, March 06, 2008 11:06 AM
> > To: Rendell Fong
> > Subject: Re: please review 28118
> >=20
> > On Thu, 6 Mar 2008 10:51:55 -0800 "Rendell Fong"
> > <rendell.fong@onstor.com> wrote:
> >=20
> > > Line 6: OS=3D`uname` is not used anymore and can be deleted unless
> > > you want to reference $OS instead of 'uname` in lines 100 & 114.
> >=20
> > fixed
> >=20
> > > Also since you are in here:  I don't understand why Ian
> > > resurrected a different SAVELINE setting for Linux.  I thought I
> > > reverted this a while back but now its come back.  It causes the
> > > first comment 3 lines repeated (over and over) again when
> > > emrscron edits the crontab file. Please verify and tell me I'm
> > > not seeing things.
> >=20
> > Are you saying SAVELINE should be 3 for both OpenBSD and Linux?
> >=20
> > > Otherwise than that its ok.
> > >=20
> > > Rendell
> > >=20
> > >=20
> > > g7r6:~# crontab -l
> > > crontab -l
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.1913 installed on Thu Mar  6 09:26:18 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.EqPwIX installed on Thu Mar  6 09:23:30 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.3764 installed on Thu Mar  6 09:19:50 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.J09YdQ installed on Thu Mar  6 09:04:49 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.3066 installed on Thu Mar  6 09:01:41 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.sXrzfl installed on Thu Mar  6 09:00:46 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.5442 installed on Thu Mar  6 08:55:29 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.NApy4k installed on Wed Mar  5 18:53:16 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.1286 installed on Wed Mar  5 11:53:41 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.Ju9l8D installed on Wed Mar  5 11:52:24 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.1338 installed on Wed Mar  5 11:50:32 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.8EnjKh installed on Wed Mar  5 11:37:57 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.1307 installed on Wed Mar  5 11:36:07 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.aChXum installed on Wed Mar  5 11:32:21 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.1301 installed on Wed Mar  5 11:28:48 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.4VcYVm installed on Wed Mar  5 11:26:24 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.2880 installed on Wed Mar  5 11:24:28 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.nevHli installed on Wed Mar  5 09:02:20 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.9113 installed on Wed Mar  5 09:00:24 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/crontab.NofF1n installed on Wed Mar  5 08:57:13 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.10428 installed on Tue Mar  4 16:19:38 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > > # DO NOT EDIT THIS FILE - edit the master and reinstall.
> > > # (/tmp/_crontmp.9471 installed on Tue Mar  4 15:49:32 2008)
> > > # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie
> > > Exp $)
> > >=20
> > > # gather config every day (at 23:05)
> > > 5       23      *       *       *       /onstor/bin/emrscron -g
> > > config
> > >=20
> > > # gather stats every hour (on the half hour)
> > > 30      *       *       *       *       /onstor/bin/emrscron -g
> > > stats
> > >=20
> > > # gather h_res_stats data every 3 min
> > > */3     *       *       *       *       /onstor/bin/emrscron -g
> > > h_res_stats
> > >=20
> > > # keep the last 7 days of config and stats files (removing excess
> > > daily at 00:53)
> > > 53      0       *       *       *       /onstor/bin/emrscron -t
> > > config; /onstor/bin/emrscron -t stats
> > >=20
> > > # roll the log files for h_res_stats and keep only 7 log files
> > > around; send files to onstor
> > > 59      23      *       *       *       /onstor/bin/emrscron -t
> > > h_res_stats; /onstor/bin/emrscron -s all
> > >=20
> > > # send the kpi file every hour (the actual minute of this cron job
> > > is random; seeded by the mac address, so not all field machines
> > > send at the same time)
> > > 29      *       *       *       *       /onstor/bin/emrscron -s
> > > kpi_stats
> > > g7r6:~#
> > >=20
> > >=20
> > > -----Original Message-----
> > > From: Andy Sharp=20
> > > Sent: Thursday, March 06, 2008 10:31 AM
> > > To: Rendell Fong
> > > Subject: please review 28118
> > >=20
> > > Change 28118 by andys@ripper on 2008/02/29 13:43:00 *pending*
> > >=20
> > >         Fix spurious error messages on Linux about
> > >         newsyslog and killing itself and so on.
> > >        =20
> > >         Also get rid of a huge pustule of trailing whitespace.
> > >        =20
> > >         reviewed by
> > >=20
> > > Affected files ...
> > >=20
> > > ... //depot/dev/nfx-tree/code/ssc-support/emrscron#16 edit
> > >=20
