X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C87D87.64707646@onstor-exch02.onstor.net>; Mon, 3 Mar 2008 16:36:23 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Mon, 3 Mar 2008 16:36:23 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E08B33F84@onstor-exch02.onstor.net>
In-Reply-To: <20080303152344.5c13c403@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: Ach9hZ++mtyjSr5KTCmkY3kB/cwueQAACnVA
References: <BB375AF679D4A34E9CA8DFA650E2B04E08B33EC5@onstor-exch02.onstor.net> <20080303152344.5c13c403@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>



>-----Original Message-----
>From: Andy Sharp
>Sent: Monday, March 03, 2008 3:24 PM
>To: Maxim Kozlovsky
>Subject: Re: Please review
>
>On Mon, 3 Mar 2008 14:01:35 -0800 "Maxim Kozlovsky"
><maxim.kozlovsky@onstor.com> wrote:
>
>> Change 28132 by maximk@maximk-13 on 2008/03/03 13:53:07 *pending*
>>
>>         Use the bit 7 of the 5th byte of the mac address to construct
>> the
>>            wwns on cougar.
>>            Reviewed by andys.
>>
>> Affected files ...
>>
>> ...
>>
//depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt
>> _bus.c#5 edit
>> ... //depot/dev/nfx-tree/Includes/cg/NFP_FP/nfx-defs.h#1 add
>> ... //depot/dev/nfx-tree/Includes/cg/NFP_TXRX/nfx-defs.h#1 add
>> ... //depot/dev/nfx-tree/code/sm-seep/seep-api.c#7 edit
>> ... //depot/dev/nfx-tree/code/sm-utils/sys-utils-linux.c#4 edit
>> ... //depot/dev/nfx-tree/code/ssc-tests/hostidtest-linux.c#2 edit
>>
>
>linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt_bus.c
>
>
>     looks good
>
>
>nfx-tree/Includes/cg/NFP_FP/nfx-defs.h
>
>
>     >>add nfx-tree/Includes/cg/NFP_FP/nfx-defs.h
>
>     line 13, is there a reason to "hide" this include in another
>     include, rather than putting it directly in the C file(s)?
>
>
>nfx-tree/Includes/cg/NFP_TXRX/nfx-defs.h
>
>
>     >>add nfx-tree/Includes/cg/NFP_TXRX/nfx-defs.h
>
>     another include file the same as the other one.  is there
>     a reason not to just add "#define NFX_EXT_MAC_SLOT 1" to
>     Includes/cg/nfx-defs.h?
>
[MK]=20
Because this define is going to have different values for FP and TXRX.
Did you read the comment?


>
>nfx-tree/code/sm-seep/seep-api.c
>
>
>     i guess
>
>
>nfx-tree/code/sm-utils/sys-utils-linux.c
>
>
>     line 55-56 what, are you some kind of C precence whiz?  please put
>     parens around precedence you desire so maintainers don't screw
>     it up.
>
[MK]=20
Of course I am a master of C pretence. Ok.
>
>nfx-tree/code/ssc-tests/hostidtest-linux.c
>
>     line 38-39 same thing here with the parens, thank you.

