X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C87A44.F57F72FE@onstor-exch02.onstor.net>; Thu, 28 Feb 2008 13:03:17 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Perlease review
Date: Thu, 28 Feb 2008 13:03:17 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9411@onstor-exch02.onstor.net>
In-Reply-To: <20080227181926.21e988bb@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Perlease review
Thread-Index: Ach5sFeohLyz/pxWQ/6AgfILmk7t1gAk6sxQ
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

I spoke with Eric and asked his advice about error messages. He said a
common tar failure problem is with customers ftp the file in ascii mode
hence the message to verify the checksum of the distribution file.

I also noticed that I wasn't checking the return value of extract and
handling the error.

Please re-review.

Larry

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, February 27, 2008 6:19 PM
To: Larry Scheer
Subject: Re: Perlease review

On Wed, 27 Feb 2008 16:08:41 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> This change is on my workspace on linux-compile but it is mounted on
> ripper: /home/larrys/perforce/trees/dev
>=20
> Change 28069 by larrys@larrys-r14-dmip on 2008/02/26 13:55:18
> *pending*
>=20
>         TED00022134
>         System does not boot after system copy init followed by system
> upgrade
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#24 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#4 edit


nfx-tree/code/ssc-nfxsh/cmd_upgrade.c


     looks good


nfx-tree/code/ssc-nfxsh/verify_install.in

     line 493 I really don't like error messages like this.  I think
     this is fine/good for the log file, but I'd rather something
     like that didn't come out on the console for customers to see.
     I know this is extra work, but perhaps a log_only version of
     'record' or a LOG_ONLY flag in opposition to the NO_RECORD flag.
     Then say something like record "Problem unpacking the distribution,
     contact customer support" on the screen, and log the other message.

     line 495 close curly should match previous indent level

     Is the problem where .fresh-flash upgrades aren't getting all
     the files needed addressed by calling extract w/o a filelist?
     I'm just trying to understand that.

