X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C878E0.66C49B04@onstor-exch02.onstor.net>; Tue, 26 Feb 2008 18:30:57 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Tue, 26 Feb 2008 18:30:57 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E08933EF6@onstor-exch02.onstor.net>
In-Reply-To: <20080226172403.02438652@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: Ach433AOo00BTg81TlinHE1/Z+AT5wAAMLmA
References: <BB375AF679D4A34E9CA8DFA650E2B04E08933977@onstor-exch02.onstor.net><20080226172244.4fdf2fa7@ripper.onstor.net> <20080226172403.02438652@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

>>
>>      line 33/66/73 if CPU and SLOT are supposed to be numbers, then
>>      the usage should say so.  maybe the correct range for the system
>>      the program is running on could be included
>
>       like 0-3 or 1-2 or whatever.  that's something that casual user
>       would likely not know.
[MK] ok
>
>
>>      line 108, I don't think you need a break after an exit.
[MK]=20
You don't need it but it is better to always put a break. People can
change code, or copy paste a block of code, it is better if the block is
always right.
>>
>>      line 113, some error messages go to stdout, some to stderr.
>>      George Bush says "unificate your error message strategy."
>>
[MK] ok
