X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C878B1.5F513136@onstor-exch02.onstor.net>; Tue, 26 Feb 2008 12:54:18 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28044
Date: Tue, 26 Feb 2008 12:54:18 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9401@onstor-exch02.onstor.net>
In-Reply-To: <20080226111230.3deb959e@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28044
Thread-Index: Ach4q4hUYAOdSl0qSXyjk6zkNvwOAAABbj2A
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

nfx-tree/code/ssc-nfxsh/verify_install.in

     fix_old_paths() has nothing for Linux systems to do and it did
     previously. (Maybe that was unnecessary.) I am not 100% sure of
     this but doesn't the shell carp about empty functions? It is not
     exactly empty because it has to do the test. Just musing...

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, February 26, 2008 11:13 AM
To: Larry Scheer
Subject: Re: please review 28044

Ping

On Mon, 25 Feb 2008 15:18:42 -0800 Andrew Sharp <andy.sharp@onstor.com>
wrote:

> OK,
>=20
> I've added those changes too.  Stupid BSD.
>=20
> Change 28044 by andys@ripper on 2008/02/25 08:32:31 *pending*
>=20
>         TED00022254 - at what point do we zip /var/log/onstor/messages
>         TED00022350 - Getting message "Usage: mktemp..."
>        =20
>         Make sure upgrade properly changes newsyslog.conf.
>         Fix calls to OpenBSDs mktemp utility.
>        =20
>         reviewed by
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#3 edit
>=20
>=20
>=20
> On Mon, 25 Feb 2008 14:45:05 -0800 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
>=20
> > nfx-tree/code/ssc-nfxsh/verify_install.in
> >=20
> >      Line 911: I know you didn't change this line but mktemp doesn't
> >      work as written in this script on BSD systems. There is a
> > defect filed for this (TED00022350). Might as well fix it while you
> > are in this routine.
> >=20
> >      Line 177: Has the same problem with mktemp usage on BSD
> > systems.
> >=20
> >      Who new mktemp wasn't the same between OpenBSD and Linux?
> >=20
> >=20
> > -----Original Message-----
> > From: Andy Sharp=20
> > Sent: Monday, February 25, 2008 1:34 PM
> > To: Larry Scheer
> > Subject: please review 28044
> >=20
> > Change 28044 by andys@ripper on 2008/02/25 08:32:31 *pending*
> >=20
> >         TED00022254 - at what point do we
> > zip /var/log/onstor/messages=20
> >         Make sure upgrade properly changes newsyslog.conf.
> >        =20
> >         reviewed by
> >=20
> > Affected files ...
> >=20
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#3 edit
> >=20
