X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C874DF.698A6090@onstor-exch02.onstor.net>; Thu, 21 Feb 2008 16:13:47 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 27961
Date: Thu, 21 Feb 2008 16:13:47 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C93E6@onstor-exch02.onstor.net>
In-Reply-To: <20080221150456.4f43e996@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 27961
Thread-Index: Ach03i0kVXh8u6fzS0yUWefVXloukAAATUsQ
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Looks fine now.

-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, February 21, 2008 3:05 PM
To: Larry Scheer
Subject: Re: please review 27961

On Thu, 21 Feb 2008 14:55:35 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> linux/Pkgs/binary/Deb/exim4-config_4.63-17_all.deb
>=20
>      looks good
>=20
> linux/Pkgs/source/exim4/Makefile
>=20
>      Lines 40 and 41. Maybe I am missing something here; but it
>      appears you are copying a file that is already inr BIN_PKG_DIR
>      to BIN_PKG_DIR?

good catch, fixed

> linux/Pkgs/source/exim4/debian.patch
>=20
>      looks good
>=20
> linux/rootfs/etc/exim4/exim4.conf.template
>=20
>      looks good
>=20
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Wednesday, February 20, 2008 11:07 PM
> To: Larry Scheer
> Subject: please review 27961
>=20
> Change 27961 by andys@ripper on 2008/02/20 10:33:21 *pending*
>=20
> 	Fix several small problems with exim4 package:
>=20
> 	Fix typo in exim4 configuration template file that was
> 	causing configuration error.
>=20
> 	Fix a few bugs in update-exim4defaults that was making
> 	it work not so well.
>=20
> 	Remove change to exim logrotate config for new log file.
> 	Log file was put in onstor directory instead and onstor
> 	logrotate config file started in cl#27953
>=20
> 	Change makefile to do the right thing if packages are up to
> 	date but not in perforce directory.
>=20
> 	Add exim4-config to list of changed packages in makefile.
>=20
> 	reviewed by
>=20
> Affected files ...
>=20
> ... //depot/dev/linux/Pkgs/binary/Deb/exim4-config_4.63-17_all.deb#1
> edit ... //depot/dev/linux/Pkgs/source/exim4/Makefile#4 edit
> ... //depot/dev/linux/Pkgs/source/exim4/debian.patch#5 edit
> ... //depot/dev/linux/rootfs/etc/exim4/exim4.conf.template#3 edit
>=20
