X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8741E.4C1189B6@onstor-exch02.onstor.net>; Wed, 20 Feb 2008 17:11:25 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 27937
Date: Wed, 20 Feb 2008 17:11:25 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C93D7@onstor-exch02.onstor.net>
In-Reply-To: <20080220153758.784f34bc@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 27937
Thread-Index: Ach0GaCK9bKRcX2+QNizD5zuLaajZwABIPpg
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

It is ok with me. Not sure what Max sees as a problem other than you
hurt his feelings.

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, February 20, 2008 3:38 PM
To: Larry Scheer
Cc: Maxim Kozlovsky
Subject: Re: please review 27937

On Wed, 20 Feb 2008 15:24:53 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> nfx-tree/Tools/defs.mk
>=20
>      If it compiles and runs basic tests then this is ok.
>=20
>      What I see as a "potential" problem is headers in Includes/eee
>      that have the same name as files in Includes/linux or
>      Includes/openbsd. I don't know if Max's intention of setting
>      OS=3Deee was just to get the include of Includes/eee or if it was
>      to get the include of Includes/eee and exlude Includes/linux
>      or Includes/openbsd. I didn't check the Includes directory for
>      headers with the same name.

There did used to be, but only because of this problem.  It's deletion
is part of the changelist ~:^)  And no, it obviously wasn't necessary,
since I didn't have to change any other file(s), just delete the
unnecessary cruft.

> -----Original Message-----
> From: Andy Sharp=20
> Sent: Wednesday, February 20, 2008 2:13 PM
> To: Larry Scheer; Maxim Kozlovsky
> Subject: please review 27937
>=20
> I'm sending this to both of you because it involves makefiles and/or
> code you may have written or know about.  Yes, I am a bit nervous
> about it.  It builds on both cougar and bobcat/openbsd, but...
>=20
> Change 27937 by andys@ripper on 2008/02/19 14:20:57 *pending*
>=20
>         Ai-eee.
>         Fix abuse of OS make variable.  This variable is limited
>         to the two SSC operating systems, either openbsd or linux.
>         eee is not one of those.  Really this variable should have
>         been called SSC_OS or something, but that's probably
>         already used for something completely different.
>        =20
>         reviewed by
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/Includes/eee/ipm-if.h#1 delete
> ... //depot/dev/nfx-tree/Tools/defs.mk#11 edit
> ... //depot/dev/nfx-tree/code/sm-elog/eee.h#1 delete
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/eee.h#1 delete
