X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C87417.CBD1AD02@onstor-exch02.onstor.net>; Wed, 20 Feb 2008 16:24:53 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 27937
Date: Wed, 20 Feb 2008 16:24:53 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C93D5@onstor-exch02.onstor.net>
In-Reply-To: <20080220141254.2692db28@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 27937
Thread-Index: Ach0Db36hCo5DKuLSl6+SFUXBufhiQACfKaw
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>,
	"Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>

nfx-tree/Tools/defs.mk

     If it compiles and runs basic tests then this is ok.

     What I see as a "potential" problem is headers in Includes/eee
     that have the same name as files in Includes/linux or
     Includes/openbsd. I don't know if Max's intention of setting
     OS=3Deee was just to get the include of Includes/eee or if it was
     to get the include of Includes/eee and exlude Includes/linux
     or Includes/openbsd. I didn't check the Includes directory for
     headers with the same name.

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, February 20, 2008 2:13 PM
To: Larry Scheer; Maxim Kozlovsky
Subject: please review 27937

I'm sending this to both of you because it involves makefiles and/or
code you may have written or know about.  Yes, I am a bit nervous about
it.  It builds on both cougar and bobcat/openbsd, but...

Change 27937 by andys@ripper on 2008/02/19 14:20:57 *pending*

        Ai-eee.
        Fix abuse of OS make variable.  This variable is limited
        to the two SSC operating systems, either openbsd or linux.
        eee is not one of those.  Really this variable should have
        been called SSC_OS or something, but that's probably
        already used for something completely different.
       =20
        reviewed by

Affected files ...

... //depot/dev/nfx-tree/Includes/eee/ipm-if.h#1 delete
... //depot/dev/nfx-tree/Tools/defs.mk#11 edit
... //depot/dev/nfx-tree/code/sm-elog/eee.h#1 delete
... //depot/dev/nfx-tree/code/sm-ipmd-lib/eee.h#1 delete
