X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C86E7C.FC16491C@onstor-exch02.onstor.net>; Wed, 13 Feb 2008 13:14:06 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review my change 27779 for patch install script
Date: Wed, 13 Feb 2008 13:14:06 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0856DE05@onstor-exch02.onstor.net>
In-Reply-To: <20080212183922.0cb80652@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review my change 27779 for patch install script
Thread-Index: Acht6aRQsy6wB+n7QIysOC0JyU6+LgAkaP3w
References: <BB375AF679D4A34E9CA8DFA650E2B04E084968E6@onstor-exch02.onstor.net> <20080212183922.0cb80652@ripper.onstor.net>
From: "Ed Kwan" <ed.kwan@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Yes, the change number is 27779.
I've moved the "method" code to get_distball() per your suggestion.
I've also added "sftp" support.  I'm adhering to the syntax of scp &
sftp, which is slightly different than those of ftp/http, so I'm listing
them all at the prompt:

Downloading the EverON software distribution.
Please enter the ftp, http, scp or sftp URL of the distribution:
  ftp://[user:password@]host[:port]/path
  http://host[:port]/path
  scp://[[user@]host:]path
  sftp://[user@]host:path
[ftp://support.onstor.com/outbound/software/EverON/3.0.1.0/22xx/EverON-3
.0.1.0BC.tar.gz]

I'm open to other suggestions.

Thanks,
Ed

> I think you meant change 27779 not 22264.  Where did 22264 come from??
>=20
> Comments:
>=20
> nfx-tree/Tools/cw_install.in
>=20
>      line 556-562 : i admit the original semantics of get_distball
were
>      akward and wrong. if you're going to do this, then might as well
>      fix that too.  which would mean moving this code into
get_distball.
>      and eliminating the 'method' argument to get_distball.
>=20
>      line 680 : just say 'ftp, http, scp URL ...' since the form is
>      standard.  you can output a sample URL if you want, but make it
>      generic for all methods.

