X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C86C17.48DEB3FE@onstor-exch02.onstor.net>; Sun, 10 Feb 2008 12:01:04 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C86C17.48DEB3FE"
References: <20080208133841.537dd80f@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E03B1C051@onstor-exch02.onstor.net> <20080208185604.497c1846@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: please review 27712
Date: Sun, 10 Feb 2008 12:00:54 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0149B649@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 27712
Thread-Index: Achqx1JZkmq3XDIDS7K8e4PRoxhUZgBT/DJv
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C86C17.48DEB3FE
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

ok

________________________________

From: Andy Sharp
Sent: Fri 2/8/2008 6:56 PM
To: Rendell Fong
Subject: Re: please review 27712



Doing the thing with verify_install.sh is harder, because it gets
unpacked from the distribution tar ball by itself and should have a
list that is from the same release.  There are other scripts that run
on the filer that need the list, so they should include it in case it
gets updated but the scripts don't.

On Fri, 8 Feb 2008 15:35:29 -0800 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Looks okay.  I'm not a makefile expert though.  One question:  Should
> the flash_install.sh script be generated like verify_install.sh during
> the make release?  Then you don't have to copy config-files and
> $OS-config-files into the release image and have to reference these
> files during execution.  Just wondering why both scripts are not
> handled in a consistent way.
>
> Other than that this is a great step in the right direction.
>
> Thanks,
> Rendell
>
>
> -----Original Message-----
> From: Andy Sharp
> Sent: Friday, February 08, 2008 1:39 PM
> To: Rendell Fong
> Subject: please review 27712
>
> Hi Rendell,
>
> I sent an email to you yesterday about this, but it probably got put
> in your spam folder.
>
> I've done a bit more work on it to make it complete last night, so I
> think it's possibly ready to check in.  Let me know.
>
> Change 27712 by andys@ripper on 2008/02/07 13:22:03 *pending*
>
>         Create one global list of config files for scripts and C code.
>       =20
>         reviewed by
>
> Affected files ...
>
> ... //depot/dev/linux/rootfs/Makefile#20 edit
> ... //depot/dev/linux/rootfs/etc/onstor/initial-config#7 edit
> ... //depot/dev/nfx-tree/Makefile#9 edit
> ... //depot/dev/nfx-tree/Tools/Linux-config-files#1 add
> ... //depot/dev/nfx-tree/Tools/OpenBSD-config-files#1 add
> ... //depot/dev/nfx-tree/Tools/config-files#1 add
> ... //depot/dev/nfx-tree/Tools/flash_install.sh#7 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs-linux.c#5 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs-openbsd.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#11 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#1 add
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#6 delete



------_=_NextPart_001_01C86C17.48DEB3FE
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<HTML dir=3Dltr><HEAD><TITLE>Re: please review 27712</TITLE>=0A=
<META http-equiv=3DContent-Type content=3D"text/html; charset=3Dunicode">=0A=
<META content=3D"MSHTML 6.00.6000.16587" name=3DGENERATOR></HEAD>=0A=
<BODY>=0A=
<DIV id=3DidOWAReplyText15722 dir=3Dltr>=0A=
<DIV dir=3Dltr><FONT face=3DArial color=3D#000000 =
size=3D2>ok</FONT></DIV></DIV>=0A=
<DIV dir=3Dltr><BR>=0A=
<HR tabIndex=3D-1>=0A=
<FONT face=3DTahoma size=3D2><B>From:</B> Andy Sharp<BR><B>Sent:</B> Fri =
2/8/2008 6:56 PM<BR><B>To:</B> Rendell Fong<BR><B>Subject:</B> Re: =
please review 27712<BR></FONT><BR></DIV>=0A=
<DIV>=0A=
<P><FONT size=3D2>Doing the thing with verify_install.sh is harder, =
because it gets<BR>unpacked from the distribution tar ball by itself and =
should have a<BR>list that is from the same release.&nbsp; There are =
other scripts that run<BR>on the filer that need the list, so they =
should include it in case it<BR>gets updated but the scripts =
don't.<BR><BR>On Fri, 8 Feb 2008 15:35:29 -0800 "Rendell =
Fong"<BR>&lt;rendell.fong@onstor.com&gt; wrote:<BR><BR>&gt; Looks =
okay.&nbsp; I'm not a makefile expert though.&nbsp; One question:&nbsp; =
Should<BR>&gt; the flash_install.sh script be generated like =
verify_install.sh during<BR>&gt; the make release?&nbsp; Then you don't =
have to copy config-files and<BR>&gt; $OS-config-files into the release =
image and have to reference these<BR>&gt; files during execution.&nbsp; =
Just wondering why both scripts are not<BR>&gt; handled in a consistent =
way.<BR>&gt;<BR>&gt; Other than that this is a great step in the right =
direction.<BR>&gt;<BR>&gt; Thanks,<BR>&gt; =
Rendell<BR>&gt;<BR>&gt;<BR>&gt; -----Original Message-----<BR>&gt; From: =
Andy Sharp<BR>&gt; Sent: Friday, February 08, 2008 1:39 PM<BR>&gt; To: =
Rendell Fong<BR>&gt; Subject: please review 27712<BR>&gt;<BR>&gt; Hi =
Rendell,<BR>&gt;<BR>&gt; I sent an email to you yesterday about this, =
but it probably got put<BR>&gt; in your spam folder.<BR>&gt;<BR>&gt; =
I've done a bit more work on it to make it complete last night, so =
I<BR>&gt; think it's possibly ready to check in.&nbsp; Let me =
know.<BR>&gt;<BR>&gt; Change 27712 by andys@ripper on 2008/02/07 =
13:22:03 =
*pending*<BR>&gt;<BR>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
 Create one global list of config files for scripts and C =
code.<BR>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR>&gt;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; reviewed by<BR>&gt;<BR>&gt; =
Affected files ...<BR>&gt;<BR>&gt; ... =
//depot/dev/linux/rootfs/Makefile#20 edit<BR>&gt; ... =
//depot/dev/linux/rootfs/etc/onstor/initial-config#7 edit<BR>&gt; ... =
//depot/dev/nfx-tree/Makefile#9 edit<BR>&gt; ... =
//depot/dev/nfx-tree/Tools/Linux-config-files#1 add<BR>&gt; ... =
//depot/dev/nfx-tree/Tools/OpenBSD-config-files#1 add<BR>&gt; ... =
//depot/dev/nfx-tree/Tools/config-files#1 add<BR>&gt; ... =
//depot/dev/nfx-tree/Tools/flash_install.sh#7 edit<BR>&gt; ... =
//depot/dev/nfx-tree/code/ssc-genlib/fs-linux.c#5 edit<BR>&gt; ... =
//depot/dev/nfx-tree/code/ssc-genlib/fs-openbsd.c#3 edit<BR>&gt; ... =
//depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#11 edit<BR>&gt; ... =
//depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#1 add<BR>&gt; ... =
//depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#6 =
delete<BR></FONT></P></DIV></BODY></HTML>
------_=_NextPart_001_01C86C17.48DEB3FE--
