X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C869C9.0F583158@onstor-exch02.onstor.net>; Thu, 7 Feb 2008 13:36:04 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 27669
Date: Thu, 7 Feb 2008 13:36:04 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9361@onstor-exch02.onstor.net>
In-Reply-To: <20080206175134.2ac576c6@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 27669
Thread-Index: AchpK/gBP/G0A/9/QJm1JDAvOPTDwwAnQtLg
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

I re-reviewed your changes all looks good.

Larry

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, February 06, 2008 5:52 PM
To: Larry Scheer
Subject: Re: please review 27669

On Wed, 6 Feb 2008 16:38:11 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c
>=20
>      Line: 35 How about adding /proc and /sys? Is this where that is
> done? And

Those are in there.

>      can subdirectories be added such as /var/empty and /lib/init/rw?

they can be, but aren't yet.  /var/empty?  say it ain't so.  crap, we
need to do something about not copying /lib/init/rw - damnit.

> I am hoping that by adding those the reboot after a system copy
>      all -i will work. If not here then in cmd_flash? Anyway rebooting
> from a flash created with system copy all -i didn't work because /proc
> and /sys were missing hence /proc was not being mounted and there were
> messages about /lib/init/rw/.ramfs missing.

/lib was also missing, as was static /dev

> nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c
>=20
>      looks good
>=20
> nfx-tree/code/ssc-nfxsh/cmd_flash.c
>=20
>      Lines 62-71 Is this where /proc /var/empty /sys /lib/init/rw
>      should be added?

they are there already, in cmd_flash-linux.c


Please re-review, I think I made some more changes after you looked at
it?  I don't know how else you would miss the os_init_dirs logic.

> nfx-tree/code/ssc-nfxsh/linux.h
>=20
>      looks good
>=20
> nfx-tree/code/ssc-nfxsh/openbsd.h
>=20
>      looks good
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Wednesday, February 06, 2008 3:46 PM
> To: Larry Scheer
> Subject: please review 27669
>=20
> Change 27669 by andys@ripper on 2008/02/06 09:36:40 *pending*
>=20
>         System copy init and system copy all porting fixes:
>        =20
>         + Need to create some common and some OS specific extra
>           directories after initializing a flash.
>        =20
>         + Linux needs a little extra logic for system copy all.
>        =20
>         reviewed by
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#14 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#17 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#9 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#9 edit
