X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8691F.F2D056CC@onstor-exch02.onstor.net>; Wed, 6 Feb 2008 17:25:31 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 27674 for review
Date: Wed, 6 Feb 2008 17:25:31 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E06648E63@onstor-exch02.onstor.net>
In-Reply-To: <20080206161713.60534ded@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 27674 for review
Thread-Index: AchpHsms1x8ylFrpQUm7uEvgUo3s7AAAEfUg
From: "Bill Nadzam" <bill.nadzam@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>


The first thing my code does, is issue an INQ Page 0x00 command to LUN
zero.

If LUN zero was there, or exported, then all was right with the world.

If LUN zero was not exported, but there as a sense device only, then the
DATA returned in the INQ page zero string did not include the VVID
field.
Which shortened the block returned. Since the code only checked for
A good return of the command, then the VVID field was accessed to be=20
stored for later.

However, since the device isn't really there, the VVID field need not be
stored.
Since we do not need to store it, there isn't a need to access that
space, and
The invalid block.

Did this ramble make sense?

=20

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, February 06, 2008 4:17 PM
To: Bill Nadzam
Subject: Re: PERFORCE change 27674 for review

On 6 Feb 2008 16:03:29 -0800 billn <bill.nadzam@onstor.com> wrote:

> Change 27674 by billn@billn-cougar on 2008/02/06 11:02:35
>=20
> 	Fix for TED00021986, problem was only seen with dmalloc debug
code=20
> installed. Also only seen with 3PARdata array with-out a lun zero=20
> exported.
> 	reviewed by mikel
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-init-disk.c#7 edit
>=20
>=20
> http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/27674?ac=3D10

OK, I'll play your silly game.  What was the bug, and what was the fix?
~:^)  Just a friendly reminder from the local neighborhood
perfarce-checkin-comment-nazi.
