X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C86886.CC6AF3C4@onstor-exch02.onstor.net>; Tue, 5 Feb 2008 23:09:14 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 27643
Date: Tue, 5 Feb 2008 23:09:14 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9350@onstor-exch02.onstor.net>
In-Reply-To: <20080205183338.6995acfd@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 27643
Thread-Index: AchoaK4VF9r7HIPHSK6to2x1J/NO+QAHWAzg
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

nfx-tree/code/ssc-genlib/fs-linux.c

     Line 26: Needs etc/gshadow and onstor/etc/snmpd.conf Since this is
     a Linux file why are there BSD files in this list.  The BSD files
     are: etc/master.passwd etc/myname hostname.sc1 etc/hostname.sc2

nfx-tree/code/ssc-genlib/fs.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c

     Line 218: I don't understand the purpose of the printf, but I
     trust you want it and need it for a reason, either that it is a
     left over from debugging.


nfx-tree/code/ssc-nfxsh/cmd_flash.c

     looks good

nfx-tree/code/ssc-nfxsh/openbsd.h

     looks good

nfx-tree/code/ssc-zebra/fs-vector.c

     looks good

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, February 05, 2008 6:34 PM
To: Larry Scheer
Subject: please review 27643

Change 27643 by andys@ripper on 2008/02/05 07:17:27 *pending*

        Fix TED22129 system config init fails on OpenBSD
       =20
        opendev function takes a different argument than open.
       =20
        reviewed by larrys

Affected files ...

... //depot/dev/nfx-tree/code/ssc-genlib/fs-linux.c#4 edit
... //depot/dev/nfx-tree/code/ssc-genlib/fs.c#6 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#13 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#16 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#6 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#7 edit
... //depot/dev/nfx-tree/code/ssc-zebra/fs-vector.c#1 edit
