X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C863E2.1D9C413D@onstor-exch02.onstor.net>; Thu, 31 Jan 2008 01:20:19 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C863E2.1D9C413D"
References: <20080130211446.2b8b30be@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: please review 27514
Date: Thu, 31 Jan 2008 01:20:00 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E042F0070@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 27514
Thread-Index: AchjyDJRsjDeFFdfTg6vY/gd8fHdNgAGeB0S
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C863E2.1D9C413D
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Looks good.


-----Original Message-----
From: Andy Sharp
Sent: Wed 1/30/2008 9:14 PM
To: Larry Scheer
Subject: please review 27514
=20
Change 27514 by andys@ripper on 2008/01/29 10:15:44 *pending*

	Move GNU licensed code out of genlib.  Because PL
	Max is afraid of the big bad GPL.

	Oh yeah, fix several bugs too, including: get_device_names()
	not switching the device names like it is supposed to;
	mount_secondary() switched to using modify_readonly_file()
	instead of it's own code, but the logic afterwards wasn't right;
	mkpath() was modifying the path argument but it shouldn't; too
	many others to keep listing them.

	reviewed by larrys

Affected files ...

... //depot/dev/nfx-tree/code/sm-sct/Makefile#2 edit
... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#5 edit
... //depot/dev/nfx-tree/code/ssc-genlib/config.linux.h#1 delete
... //depot/dev/nfx-tree/code/ssc-genlib/config.openbsd.h#1 delete
... //depot/dev/nfx-tree/code/ssc-genlib/fs-api.h#3 edit
... //depot/dev/nfx-tree/code/ssc-genlib/fs.c#4 edit
... //depot/dev/nfx-tree/code/ssc-genlib/log.c#1 delete
... //depot/dev/nfx-tree/code/ssc-genlib/log.h#1 delete
... //depot/dev/nfx-tree/code/ssc-genlib/memory.c#1 delete
... //depot/dev/nfx-tree/code/ssc-genlib/memory.h#1 delete
... //depot/dev/nfx-tree/code/ssc-genlib/redo-hosts.c#2 delete
... //depot/dev/nfx-tree/code/ssc-genlib/vector.c#1 delete
... //depot/dev/nfx-tree/code/ssc-genlib/vector.h#1 delete
... //depot/dev/nfx-tree/code/ssc-genlib/zebra.h#1 delete
... //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.c#3 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#10 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/buffer.c#3 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_admin.c#6 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_arp.c#3 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#8 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#10 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cifs.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cifssrvr.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cluster.c#21 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cshare.c#7 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_disk.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_domain.c#9 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#9 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_filesystem.c#9 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#12 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_gns.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_help.c#17 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_idmap.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_interface.c#13 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_localmap.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_localuseraccounts.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_lvol.c#17 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nameservice.c#3 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c#12 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_port.c#8 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_privileges.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#10 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_quota.c#12 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_raid.c#3 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_rcon.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_remoteaccess.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_route.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sanm.c#11 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_scsi.c#6 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_snapshot.c#12 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_snmp.c#6 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_spool.c#17 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_stats.c#12 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_symlinkmap.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysHealth.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysdvt.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-linux.c#7 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#7 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#39 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_tape.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#20 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vif.c#7 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#39 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vscan.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vsvr.c#17 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/command.c#6 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/command.h#2 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/linklist.c#3 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#9 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/vty.c#8 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-linux.c#2 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-openbsd.c#11 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh.c#9 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_config.c#8 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_main.c#11 edit
... //depot/dev/nfx-tree/code/ssc-zebra/Makefile#1 add
... //depot/dev/nfx-tree/code/ssc-zebra/config.linux.h#1 branch
... //depot/dev/nfx-tree/code/ssc-zebra/config.openbsd.h#1 branch
... //depot/dev/nfx-tree/code/ssc-zebra/fs-vector.h#1 add
... //depot/dev/nfx-tree/code/ssc-zebra/log.c#1 branch
... //depot/dev/nfx-tree/code/ssc-zebra/log.h#1 branch
... //depot/dev/nfx-tree/code/ssc-zebra/memory.c#1 branch
... //depot/dev/nfx-tree/code/ssc-zebra/memory.h#1 branch
... //depot/dev/nfx-tree/code/ssc-zebra/vector.c#1 branch
... //depot/dev/nfx-tree/code/ssc-zebra/vector.h#1 branch
... //depot/dev/nfx-tree/code/ssc-zebra/zebra.h#1 branch



------_=_NextPart_001_01C863E2.1D9C413D
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>RE: please review 27514</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>Looks good.<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Wed 1/30/2008 9:14 PM<BR>
To: Larry Scheer<BR>
Subject: please review 27514<BR>
<BR>
Change 27514 by andys@ripper on 2008/01/29 10:15:44 *pending*<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Move GNU licensed code out of =
genlib.&nbsp; Because PL<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Max is afraid of the big bad =
GPL.<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Oh yeah, fix several bugs =
too, including: get_device_names()<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; not switching the device =
names like it is supposed to;<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; mount_secondary() switched to =
using modify_readonly_file()<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; instead of it's own code, but =
the logic afterwards wasn't right;<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; mkpath() was modifying the =
path argument but it shouldn't; too<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; many others to keep listing =
them.<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; reviewed by larrys<BR>
<BR>
Affected files ...<BR>
<BR>
... //depot/dev/nfx-tree/code/sm-sct/Makefile#2 edit<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#5 edit<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/config.linux.h#1 delete<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/config.openbsd.h#1 delete<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/fs-api.h#3 edit<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/fs.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/log.c#1 delete<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/log.h#1 delete<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/memory.c#1 delete<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/memory.h#1 delete<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/redo-hosts.c#2 delete<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/vector.c#1 delete<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/vector.h#1 delete<BR>
... //depot/dev/nfx-tree/code/ssc-genlib/zebra.h#1 delete<BR>
... //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.c#3 =
edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#10 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/buffer.c#3 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_admin.c#6 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_arp.c#3 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#8 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#10 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cifs.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cifssrvr.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cluster.c#21 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cshare.c#7 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_disk.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_domain.c#9 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#9 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_filesystem.c#9 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#12 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#5 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_gns.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_help.c#17 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_idmap.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_interface.c#13 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_localmap.c#5 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_localuseraccounts.c#5 =
edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_lvol.c#17 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nameservice.c#3 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c#12 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_port.c#8 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_privileges.c#5 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#10 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_quota.c#12 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_raid.c#3 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_rcon.c#5 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_remoteaccess.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_route.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sanm.c#11 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_scsi.c#6 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_snapshot.c#12 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_snmp.c#6 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_spool.c#17 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_stats.c#12 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_symlinkmap.c#5 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysHealth.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysdvt.c#5 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-linux.c#7 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#7 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#39 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_tape.c#4 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#20 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vif.c#7 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#39 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vscan.c#5 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vsvr.c#17 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/command.c#6 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/command.h#2 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/linklist.c#3 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#9 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/vty.c#8 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-linux.c#2 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-openbsd.c#11 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh.c#9 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_config.c#8 edit<BR>
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_main.c#11 edit<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/Makefile#1 add<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/config.linux.h#1 branch<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/config.openbsd.h#1 branch<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/fs-vector.h#1 add<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/log.c#1 branch<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/log.h#1 branch<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/memory.c#1 branch<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/memory.h#1 branch<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/vector.c#1 branch<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/vector.h#1 branch<BR>
... //depot/dev/nfx-tree/code/ssc-zebra/zebra.h#1 branch<BR>
<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C863E2.1D9C413D--
