X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C85A0B.F17C550F@onstor-exch02.onstor.net>; Fri, 18 Jan 2008 12:54:32 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 27377 for review
Date: Fri, 18 Jan 2008 12:54:32 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E03E9A554@onstor-exch02.onstor.net>
In-Reply-To: <20080118113237.1aed5610@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 27377 for review
Thread-Index: AchaCOEm8N+8gyhkSuuRlJOLid4pAQAAEvMQ
From: "Chris Vandever" <chris.vandever@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

If the names are used outside of clustering then the definitions should
just be moved to a file in Includes, like nfx-defs.h, and the code
should use the defines rather than hard coded values.

ChrisV

-----Original Message-----
From: Andy Sharp=20
Sent: Friday, January 18, 2008 11:33 AM
To: Chris Vandever
Subject: Re: PERFORCE change 27377 for review

Hey, I can clean up my own messes, thank you very much.  Just point me
in the right direction, set appropriate level on the taser before
applying, and off I go.

BTW, thanks for blaming me when really mostly just macro-izing
clusterdb file names ~:^)  Actually what I was going to say is that we
have hard coded some of those file names in files like
ssc-genlib/fs-OS.c (actually I think it's currently in
ssc-nfxsh/cmd_flash-openbsd.c but I'm in the process of fixing that)
and perhaps if you think they might change we should consider ways to
parameterize them there as well.

Cheers,

a

On 17 Jan 2008 18:03:16 -0800 chrisv <chris.vandever@onstor.com> wrote:

> Change 27377 by chrisv@chrisv-dev3 on 2008/01/17 13:03:55
>=20
> 	Cleanup from #27104 (Agile training day).=20
> =09
> 	Reviewed by JamesK
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/ssc-cluster/clusdb-tools.c#8 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-api.c#10 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-api.h#3 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#20 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-server.c#6 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-test.c#11 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.c#6 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.h#6 edit
> ... //depot/dev/nfx-tree/code/ssc-openafs-ubik/beacon.c#10 edit
>=20
>=20
> http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/27377?ac=3D10
