X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8588A.C8FCE23E@onstor-exch02.onstor.net>; Wed, 16 Jan 2008 14:57:28 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review change: re-arranging code from sm-opt and ssc-optlib directories
Date: Wed, 16 Jan 2008 14:57:28 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C92CF@onstor-exch02.onstor.net>
In-Reply-To: <20080116135158.714b895d@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review change: re-arranging code from sm-opt and ssc-optlib directories
Thread-Index: AchYigQ0x+DE3+K2TVSo/WFUPQqtUgAADttA
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Okay your changes look fine. Just a request, you don't have to do this
if you don't want to. A number of Makefiles have -Wl,-Bstatic -lssl
-Wl,-Bdynamic this can change to just -lssl. It is something I have been
wanting to do for a while just haven't gotten around to it. Since you
are in those files it wouldn't hurt to remove the static linking of
libssl.=20

Just a thought.

Larry

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, January 16, 2008 1:52 PM
To: Larry Scheer
Cc: Tim Gardner; Sripal Surendiran (HCL)
Subject: Re: please review change: re-arranging code from sm-opt and
ssc-optlib directories

Use the script, Luke, it sets the client properly ~:^)

On Wed, 16 Jan 2008 13:31:48 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Did not see any differences in the following Makefiles:
>=20
> code/sendmail/Makefile
> code/sm-bsd-snmpd/agent/Makefile
> code/sm-ea/Makefile
> code/sm-event/Makefile
> code/sm-evm/Makefile
>=20
> It looks like nearly all of the Makefiles I only saw differences in
> nfxsh/Makefile.
>=20
> Did you plan on changing the PKG variable's value in these Makefiles?
>=20
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Friday, January 11, 2008 10:51 PM
> To: Larry Scheer; Tim Gardner; Sripal Surendiran (HCL)
> Subject: please review change: re-arranging code from sm-opt and
> ssc-optlib directories
>=20
> I am porting ssc-nfxsh/cmd_flash.c to linux (actually, I'm porting it
> period, as it was never ported) and in the process discovered that
> some refactoring needed to take place.  Most of the files changed in
> this change list are just being moved, or they need to be modified
> slightly because of the moved files.
>=20
> The files that are being moved out of sm-opt and ssc-optlib will also
> need modifying, but in this checkin they are only moved.  A subsequent
> checkin will fix them w/o losing the history of where they came from.
> Those changes have already been made and tested: it builds at least
> ~:^)
>=20
> All the code from these directories is moved to ssc-genlib, except
> the initial-config stuff, which gets its own directory now --
> ssc-initial-config -- which makes sense because there will probably be
> more files added to that directory soon.
>=20
>=20
> Change 27264 by andys@ripper-temp on 2008/01/09 09:53:31 *pending*
>=20
> 	Precursor to porting the cmd_flash code.
> =09
> 	Step 1: flower arranging.
> =09
> 	The sm-opt and ssc-optlib directories at one time had rational
> 	stuff in them, but not anymore.  It's time to move this code,
> 	and consolidate it with other code, to a place that is more
> 	apropriate for what it currently does -- ssc-genlib.
> =09
> 	Move the initial config stuff out of ssc-optlib into it's own
> 	directory, because it doesn't belong where it is or anywhere
> 	else I can think of.
> =09
> 	Fix the includes for all C files that were including one of
> 	the moved header files opt-api.h (now renamed to optlib-api.h)
> 	and opt-fs-internal.h (now renamed to fs.h).  opt-api.h will
> 	likely get folded into ssc-genlib/genlib.h.
> =09
> 	Fix the makefiles that were specifying the opt library and
> 	sm-opt and ssc-optlib directories.
> =09
> 	The moved files themselves need fixing, which will be done in
> 	a separate checkin immediately following this one.
> =09
> 	Delete unused source file sm-ipmd/ipmd-vif.c
> =09
> 	Reviewed by
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/Includes/opt-msgs.h#1 branch
> ... //depot/dev/nfx-tree/Makefile.ssc#9 edit
> ... //depot/dev/nfx-tree/Makefile.tmfc#1 edit
> ... //depot/dev/nfx-tree/Tools/genmake#1 edit
> ... //depot/dev/nfx-tree/code/sendmail/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/agent_onstor.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-coredump/coredump.h#2 edit
> ... //depot/dev/nfx-tree/code/sm-ea/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/sm-elog/openbsd.h#1 edit
> ... //depot/dev/nfx-tree/code/sm-event/Makefile#3 edit
> ... //depot/dev/nfx-tree/code/sm-event/asd.c#8 edit
> ... //depot/dev/nfx-tree/code/sm-event/event-api.h#4 edit
> ... //depot/dev/nfx-tree/code/sm-event/event-as-linux.c#1 edit
> ... //depot/dev/nfx-tree/code/sm-event/event-as-openbsd.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-event/event-as.c#10 edit
> ... //depot/dev/nfx-tree/code/sm-event/event-as.h#4 edit
> ... //depot/dev/nfx-tree/code/sm-event/event.c#11 edit
> ... //depot/dev/nfx-tree/code/sm-evm/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/sm-evm/evm-com-defs.h#12 edit
> ... //depot/dev/nfx-tree/code/sm-file/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/sm-fs/Makefile#2 edit
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/ipmd-lib.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-ipmd/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd-kern-linux.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd-kern-openbsd.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd-util.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd-vif.c#4 delete
> ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd.c#8 edit
> ... //depot/dev/nfx-tree/code/sm-opt/Makefile#3 delete
> ... //depot/dev/nfx-tree/code/sm-opt/eee.h#1 delete
> ... //depot/dev/nfx-tree/code/sm-opt/fs-linux.c#5 delete
> ... //depot/dev/nfx-tree/code/sm-opt/fs-openbsd.c#7 delete
> ... //depot/dev/nfx-tree/code/sm-opt/fs.c#3 delete
> ... //depot/dev/nfx-tree/code/sm-opt/linux.h#2 delete
> ... //depot/dev/nfx-tree/code/sm-opt/openbsd.h#3 delete
> ... //depot/dev/nfx-tree/code/sm-opt/opt-api.h#5 delete
> ... //depot/dev/nfx-tree/code/sm-opt/opt-fs-internal.h#2 delete
> ... //depot/dev/nfx-tree/code/sm-opt/tfs.c#2 delete
> ... //depot/dev/nfx-tree/code/sm-sct/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/sm-sct/taskmgr.c#12 edit
> ... //depot/dev/nfx-tree/code/sm-spm/spm.h#4 edit
> ... //depot/dev/nfx-tree/code/sm-tape/tape-msg.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-tape/tape-rmc.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-authen-lib/cifs-map-cfg.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-authentication/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/Makefile#2 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#18 edit
> ... //depot/dev/nfx-tree/code/ssc-elog/Makefile#2 edit
> ... //depot/dev/nfx-tree/code/ssc-elog/elog.c#6 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#3 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs-api.h#1 branch
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs-linux.c#1 branch
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs-linux.h#1 branch
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs-openbsd.c#1 branch
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs-openbsd.h#1 branch
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs.c#1 branch
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs.h#1 branch
> ... //depot/dev/nfx-tree/code/ssc-genlib/redo-hosts.c#1 branch
> ... //depot/dev/nfx-tree/code/ssc-genlib/tfs.c#1 branch
> ... //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c#9 edit
> ... //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-openbsd.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-initial-config/Makefile#1 add
> ... //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.c#1
> branch ...
> //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.h#1
> branch ... //depot/dev/nfx-tree/code/ssc-modify-ro/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/ssc-modify-ro/modify-ro.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-ndmp/Makefile#2 edit
> ... //depot/dev/nfx-tree/code/ssc-ndmp/ndmp-agil-tbl.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxnis/cfg_nfxnis.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_admin.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#8 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cluster.c#17 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#9 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#14 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_idmap.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_ndmp.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_privileges.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#35 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#16 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#6 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-openbsd.c#9 edit
> ... //depot/dev/nfx-tree/code/ssc-optlib/Makefile#6 delete
> ... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.c#11 delete
> ... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.h#5 delete
> ... //depot/dev/nfx-tree/code/ssc-optlib/redo_hosts.c#2 delete
> ... //depot/dev/nfx-tree/code/ssc-sshd-kb5/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/ssc-tests/Makefile#5 edit
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/Makefile#2 edit
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils-linux.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils-openbsd.c#2
> edit ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils.c#9 edit
> ... //depot/dev/nfx-tree/code/ssc-vsd/Makefile#2 edit
> ... //depot/dev/nfx-tree/code/ssc-vsd/vs-ipm.c#10 edit
> ... //depot/dev/nfx-tree/code/ssc-vtm/Makefile#1 edit
>=20
