X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C84DB1.D2D44B63@onstor-exch02.onstor.net>; Wed, 2 Jan 2008 19:39:12 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: review 27135 flash_install
Date: Wed, 2 Jan 2008 19:39:12 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9275@onstor-exch02.onstor.net>
In-Reply-To: <20080102163220.4be2839d@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: review 27135 flash_install
Thread-Index: AchNoBozM/wfNWwsTDyq0OgVfGxUzAACu62Q
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

No master.passwd is a BSD only thing it should be in a BSD only list.

File mdrive_fstab: Why are all the partitions being ignored for fsck? Is
this correct? Even if they are ext3 file systems shouldn't sda1, sda3,
and sda4 have a value of 1? I am not an expert on this though, just
paranoid.
My Ubuntu desktop has 1 for the fsck value for its ext3 file system in
its /etc/fstab file. (So does the Red Hat systems I checked.)
Also you are using "defaults" for the mount options for / shouldn't this
be something that includes ro? Perhaps
ro,suid,dev,exec,auto,nouser,async? Or do you want sync or dirsync to
replace async?

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, January 02, 2008 4:32 PM
To: Larry Scheer
Subject: Re: review 27135 flash_install

On Wed, 2 Jan 2008 16:13:56 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Line 9: COMMON_CONFIGS... etc/master.passwd doesn't exist in Linux.
> The myname file is also an OpenBSD creation.=20

OK, I moved myname to BSD and added etc/hostname to LINUX.  I left
master.passwd 'cuz maybe we should have such a thing in linux, but it
won't bomb if we don't.


> Do you have a mdrive_fstab for Linux? This should be added to
> dev/linux/rootfs/etc and linux/rootfs/Makefile before or on the same
> day this change goes in.

OK, added a linux mdrive_fstab file.  Let me know what you think.



Change 27135 by andys@ripper on 2007/12/21 17:28:23 *pending*

        Port flash_install.sh to work on Linux as well as OpenBSD.
        Remove dead flash512 file.

Affected files ...

... //depot/dev/linux/rootfs/etc/mdrive_fstab#1 add
... //depot/dev/nfx-tree/Tools/flash512#1 delete
... //depot/dev/nfx-tree/Tools/flash_install.sh#3 edit
