X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C84920.CB8BC172@onstor-exch02.onstor.net>; Fri, 28 Dec 2007 00:10:58 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C84920.CB8BC172"
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9269@onstor-exch02.onstor.net><20071227184510.03ed0747@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E042F0006@onstor-exch02.onstor.net> <20071227224615.55abc135@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: Code review request
Date: Fri, 28 Dec 2007 00:10:58 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E042F0007@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Code review request
Thread-Index: AchJHVixuUO4/kn3ToCyje8boZAJXwAAly0o
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C84920.CB8BC172
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Yup uname gives the same results as uname -s on both Linux and OpenBSD =
try it sometime!

Yea, I still have to create the link.It is the cleanest solution. =
Creating the files will mess with the BOM file in a way I don't want. =
The link will exist on 3.X systems anywat -- we never remove it with any =
install. Unless we do a BSD release for 4.0 the link won't exist on 4.0 =
systems. The only other thing I can think of is have verify_install =
remove the link at the end. Not real clean and I wonder if it is worth =
the effort.

Thanks for the review=20

Larry


-----Original Message-----
From: Andy Sharp
Sent: Thu 12/27/2007 10:46 PM
To: Larry Scheer
Subject: Re: Code review request
=20
On Thu, 27 Dec 2007 22:01:14 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Ok I removed the Host line in my client. You should be able to access
> it from ripper.
>=20
>=20
>=20
> -----Original Message-----
> From: Andy Sharp
> Sent: Thu 12/27/2007 6:45 PM
> To: Larry Scheer
> Subject: Re: Code review request
> =20
> Oooh, close.  I get
> Client 'larrys-r14-dmip' can only be used from host
> 'linux-compile.onstor.net'.
>=20
> I should be able to do it from linux-compile, but there is some weird
> problem happening where remote X windows aren't working from
> linux-compile today.  You should just be able to adjust the client and
> remove the host field value.  IIRC.
>=20
> On Thu, 27 Dec 2007 17:21:06 -0800 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
>=20
> > Andy,
> >      My workspace is mounted on ripper as:
> > /home/larrys/perforce/trees/dev
> > So you should be able to diff these file from ripper.
> >=20
> > This fixes the "broken system upgrade problem"
> >=20
> > Verify_install.sh is still a work in progress. The changes here I am
> > most interested in getting in are the path changes. I probably have
> > much more work to do using md5sum on the Linux side. I just cobbled
> > some changes together that switch between cksum and md5sum, for now.
> > Right now I want to make sure I didn't break the BSD stuff.
> >=20
> > I have another change list coming that fixes the descr files (once I
> > test my fixes.)
> >=20
> > Change 27166 by larrys@larrys-r14-dmip on 2007/12/27 16:12:58
> > *pending*
> >=20
> >         Add compatibility with older versions of cmd_upgrade code=20
> >         attempting to upgrade to the newer system "sans agile."
> >         Reviewed by: AndyS
> >=20
> > Affected files ...
> >=20
> > ... //depot/dev/nfx-tree/Makefile#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#4 edit
> > ... //depot/dev/nfx-tree/openbsd.mk#4 edit



nfx-tree/Makefile

     looks good

nfx-tree/code/ssc-nfxsh/verify_install.sh

     heh-heh line 44, does that work?  i would assume that you have
     to do uname -s at least.

     rest is fine

nfx-tree/openbsd.mk

     so basically what you're saying is we still have to create the
     compat symlink?  can't we just put those files there, no symlink?
     create a /usr/local/agile/bin/verify_install.sh and whatever?  then
     the upgrade program will execute /usr/local/bin/verify_install.sh
     ...  ferk.  nm.



------_=_NextPart_001_01C84920.CB8BC172
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>RE: Code review request</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>Yup uname gives the same results as uname -s on both =
Linux and OpenBSD try it sometime!<BR>
<BR>
Yea, I still have to create the link.It is the cleanest solution. =
Creating the files will mess with the BOM file in a way I don't want. =
The link will exist on 3.X systems anywat -- we never remove it with any =
install. Unless we do a BSD release for 4.0 the link won't exist on 4.0 =
systems. The only other thing I can think of is have verify_install =
remove the link at the end. Not real clean and I wonder if it is worth =
the effort.<BR>
<BR>
Thanks for the review<BR>
<BR>
Larry<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Thu 12/27/2007 10:46 PM<BR>
To: Larry Scheer<BR>
Subject: Re: Code review request<BR>
<BR>
On Thu, 27 Dec 2007 22:01:14 -0800 &quot;Larry Scheer&quot;<BR>
&lt;larry.scheer@onstor.com&gt; wrote:<BR>
<BR>
&gt; Ok I removed the Host line in my client. You should be able to =
access<BR>
&gt; it from ripper.<BR>
&gt;<BR>
&gt;<BR>
&gt;<BR>
&gt; -----Original Message-----<BR>
&gt; From: Andy Sharp<BR>
&gt; Sent: Thu 12/27/2007 6:45 PM<BR>
&gt; To: Larry Scheer<BR>
&gt; Subject: Re: Code review request<BR>
&gt;&nbsp;<BR>
&gt; Oooh, close.&nbsp; I get<BR>
&gt; Client 'larrys-r14-dmip' can only be used from host<BR>
&gt; 'linux-compile.onstor.net'.<BR>
&gt;<BR>
&gt; I should be able to do it from linux-compile, but there is some =
weird<BR>
&gt; problem happening where remote X windows aren't working from<BR>
&gt; linux-compile today.&nbsp; You should just be able to adjust the =
client and<BR>
&gt; remove the host field value.&nbsp; IIRC.<BR>
&gt;<BR>
&gt; On Thu, 27 Dec 2007 17:21:06 -0800 &quot;Larry Scheer&quot;<BR>
&gt; &lt;larry.scheer@onstor.com&gt; wrote:<BR>
&gt;<BR>
&gt; &gt; Andy,<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; My workspace is mounted on =
ripper as:<BR>
&gt; &gt; /home/larrys/perforce/trees/dev<BR>
&gt; &gt; So you should be able to diff these file from ripper.<BR>
&gt; &gt;<BR>
&gt; &gt; This fixes the &quot;broken system upgrade problem&quot;<BR>
&gt; &gt;<BR>
&gt; &gt; Verify_install.sh is still a work in progress. The changes =
here I am<BR>
&gt; &gt; most interested in getting in are the path changes. I probably =
have<BR>
&gt; &gt; much more work to do using md5sum on the Linux side. I just =
cobbled<BR>
&gt; &gt; some changes together that switch between cksum and md5sum, =
for now.<BR>
&gt; &gt; Right now I want to make sure I didn't break the BSD =
stuff.<BR>
&gt; &gt;<BR>
&gt; &gt; I have another change list coming that fixes the descr files =
(once I<BR>
&gt; &gt; test my fixes.)<BR>
&gt; &gt;<BR>
&gt; &gt; Change 27166 by larrys@larrys-r14-dmip on 2007/12/27 =
16:12:58<BR>
&gt; &gt; *pending*<BR>
&gt; &gt;<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Add =
compatibility with older versions of cmd_upgrade code<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; attempting to =
upgrade to the newer system &quot;sans agile.&quot;<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Reviewed by: =
AndyS<BR>
&gt; &gt;<BR>
&gt; &gt; Affected files ...<BR>
&gt; &gt;<BR>
&gt; &gt; ... //depot/dev/nfx-tree/Makefile#6 edit<BR>
&gt; &gt; ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#4 =
edit<BR>
&gt; &gt; ... //depot/dev/nfx-tree/openbsd.mk#4 edit<BR>
<BR>
<BR>
<BR>
nfx-tree/Makefile<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp; looks good<BR>
<BR>
nfx-tree/code/ssc-nfxsh/verify_install.sh<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp; heh-heh line 44, does that work?&nbsp; i would =
assume that you have<BR>
&nbsp;&nbsp;&nbsp;&nbsp; to do uname -s at least.<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp; rest is fine<BR>
<BR>
nfx-tree/openbsd.mk<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp; so basically what you're saying is we still =
have to create the<BR>
&nbsp;&nbsp;&nbsp;&nbsp; compat symlink?&nbsp; can't we just put those =
files there, no symlink?<BR>
&nbsp;&nbsp;&nbsp;&nbsp; create a /usr/local/agile/bin/verify_install.sh =
and whatever?&nbsp; then<BR>
&nbsp;&nbsp;&nbsp;&nbsp; the upgrade program will execute =
/usr/local/bin/verify_install.sh<BR>
&nbsp;&nbsp;&nbsp;&nbsp; ...&nbsp; ferk.&nbsp; nm.<BR>
<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C84920.CB8BC172--
