X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C84428.1910CE24@onstor-exch02.onstor.net>; Fri, 21 Dec 2007 16:20:38 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 27121 for review
Date: Fri, 21 Dec 2007 16:20:38 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E03B1BFC6@onstor-exch02.onstor.net>
In-Reply-To: <20071221143316.72a2176c@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 27121 for review
Thread-Index: AchEIXq39fup/lgiT3K78CibSgbRuQAAlaVg
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>
Cc: "Tim Gardner" <tim.gardner@onstor.com>,
	"Larry Scheer" <larry.scheer@onstor.com>

I was planning on fixing the list of config files but that's in a
separate change list (not submitted) since you suggested my original
change list #26788 be separated into multiple change lists.

I'm thinking of not submitting the rest of the changes since this whole
area is so contentious.  Whoever ends up being responsible for getting
upgrade and system config reset|copy|restore to work is welcome to
plagiarize my tentative changes.  You guys are in a better position to
work on this since you have a system.

Rendell


-----Original Message-----
From: Andy Sharp=20
Sent: Friday, December 21, 2007 2:33 PM
To: Rendell Fong
Cc: Tim Gardner; Larry Scheer
Subject: Re: PERFORCE change 27121 for review

On 21 Dec 2007 12:12:00 -0800 Rendell Fong <rendell.fong@onstor.com>
wrote:

> Change 27121 by rendellf@rendellf on 2007/12/21 12:00:05
>=20
> 	Update directory path for mount/umount command for Linux.
> 	   Reviewed By: LarryS
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/sm-opt/linux.h#2 edit
> ... //depot/dev/nfx-tree/code/sm-opt/openbsd.h#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#9 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#15 edit
>=20
>=20
> http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/27121?ac=3D10

Hi Rendell/Larry,

A few notes on these changes:

nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c:

line 952:
I have a feeling Linux uses /etc/defaultroute rather than /etc/mygate

Basically, it looks like cmd_flash.c was never ported, just copied to
two files and the exact minimum changes made to permit compiling.  So
some of the changes Rendell has made, while excellent improvements in
portability, are only in the Linux version.  Unless Rendell is the
original person who was supposed to do this file, it's not his fault,
but I just wanted to make sure we note that this work still has yet to
be done.  Ie., cmd_flash.c has not actually been ported.

nfx-tree/code/ssc-nfxsh/cmd_upgrade.c:

line 1742:

please no ifdefs

The password database files need to be copied, not reproduced.  And the
equivalent files on Linux need to be copied too, namely /etc/shadow
and /etc/gshadow, so these files should be added to the list of files
to be copied for each OS, even though that part of sm-opt HASN'T BEEN
PORTED EITHER!  So this can just be handled by having all the right
files in the config files list.

I should note that there might be some good reason why these areas
weren't ported, really I just want to make sure that we know that it
needs to be done.

Cheers,

a


