Received: from mail.onstor.com ([66.201.51.107]) by onstor-exch02.onstor.net with Microsoft SMTPSVC(6.0.3790.1830);
	 Thu, 22 Nov 2007 07:40:17 -0800
Received: from ftp.linux-mips.org ([194.74.144.162]) by mail.onstor.com with Microsoft SMTPSVC(6.0.3790.1830);
	 Thu, 22 Nov 2007 07:40:17 -0800
Received: from localhost.localdomain ([127.0.0.1]:38595 "EHLO
	ftp.linux-mips.org") by ftp.linux-mips.org with ESMTP
	id S20025660AbXKVPj5 (ORCPT <rfc822;andy.sharp@onstor.com>);
	Thu, 22 Nov 2007 15:39:57 +0000
Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 22 Nov 2007 15:39:36 +0000 (GMT)
Received: from mba.ocn.ne.jp ([122.1.235.107]:10950 "HELO smtp.mba.ocn.ne.jp")
	by ftp.linux-mips.org with SMTP id S20025821AbXKVPj1 (ORCPT
	<rfc822;linux-mips@linux-mips.org>); Thu, 22 Nov 2007 15:39:27 +0000
Received: from localhost (p8045-ipad307funabasi.chiba.ocn.ne.jp [123.217.186.45])
	by smtp.mba.ocn.ne.jp (Postfix) with ESMTP
	id D7C889521; Fri, 23 Nov 2007 00:39:20 +0900 (JST)
Date:	Fri, 23 Nov 2007 00:41:32 +0900 (JST)
Message-Id: <20071123.004132.61510296.anemo@mba.ocn.ne.jp>
To:	linux-mips@linux-mips.org
Cc:	ralf@linux-mips.org
Subject: Re: [MIPS] irq_cpu: use handle_percpu_irq handler to avoid
 dropping interrupts.
From:	Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <S20032632AbXKOURg/20071115201736Z+24020@ftp.linux-mips.org>
References: <S20032632AbXKOURg/20071115201736Z+24020@ftp.linux-mips.org>
X-Fingerprint: 6ACA 1623 39BD 9A94 9B1A  B746 CA77 FE94 2874 D52F
X-Pgp-Public-Key: http://wwwkeys.pgp.net/pks/lookup?op=get&search=0x2874D52F
X-Mailer: Mew version 5.2 on Emacs 21.4 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-archive-position: 17560
X-ecartis-version: Ecartis v1.0.0
Sender:	linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: anemo@mba.ocn.ne.jp
Precedence: bulk
X-list:	linux-mips
Return-Path: linux-mips-bounce@linux-mips.org
X-OriginalArrivalTime: 22 Nov 2007 15:40:17.0549 (UTC) FILETIME=[FB6B8BD0:01C82D1D]

On Thu, 15 Nov 2007 20:17:31 +0000, linux-mips@linux-mips.org wrote:
> Subject: [MIPS] irq_cpu: use handle_percpu_irq handler to avoid dropping interrupts.
> Author: Ralf Baechle <ralf@linux-mips.org> Thu Nov 15 19:37:15 2007 +0000
> Commit: eebc88e5d2cffc07b969c8f426552a44e5ce51f8
> Gitweb: http://www.linux-mips.org/g/linux/eebc88e5
> Branch: master

This might broke probe_irq_on()/probe_irq_off(), since
handle_percpu_irq() does not check IRQ_WAITING bit.

This is a quick fix.  But I'm not sure where is the right place to fix...

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/arch/mips/kernel/irq_cpu.c b/arch/mips/kernel/irq_cpu.c
index 0ee2567..9d97d4b 100644
--- a/arch/mips/kernel/irq_cpu.c
+++ b/arch/mips/kernel/irq_cpu.c
@@ -114,7 +114,9 @@ void __init mips_cpu_irq_init(void)
 		for (i = irq_base; i < irq_base + 2; i++)
 			set_irq_chip(i, &mips_mt_cpu_irq_controller);
 
-	for (i = irq_base + 2; i < irq_base + 8; i++)
+	for (i = irq_base + 2; i < irq_base + 8; i++) {
 		set_irq_chip_and_handler(i, &mips_cpu_irq_controller,
 					 handle_percpu_irq);
+		irq_desc[i].status |= IRQ_NOPROBE;
+	}
 }

