Received: from mail.onstor.com ([66.201.51.107]) by onstor-exch02.onstor.net with Microsoft SMTPSVC(6.0.3790.1830);
	 Mon, 28 Jul 2008 07:04:22 -0700
Received: from chiesmta2-1.messageone.com ([216.203.30.55]) by mail.onstor.com with Microsoft SMTPSVC(6.0.3790.1830);
	 Mon, 28 Jul 2008 07:04:22 -0700
Received: from ftp.linux-mips.org (ftp.linux-mips.org [213.58.128.207])
	by chiesmta2-1.messageone.com (8.13.8/8.13.8) with ESMTP id m6SE4Kwr026385
	for <andy.sharp@onstor.com>; Mon, 28 Jul 2008 09:04:21 -0500
Received: from localhost.localdomain ([127.0.0.1]:38609 "EHLO
	ftp.linux-mips.org") by ftp.linux-mips.org with ESMTP
	id S20025189AbYG1ODr (ORCPT <rfc822;andy.sharp@onstor.com>);
	Mon, 28 Jul 2008 15:03:47 +0100
Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 28 Jul 2008 15:03:30 +0100 (BST)
Received: from mba.ocn.ne.jp ([122.1.235.107]:35269 "HELO smtp.mba.ocn.ne.jp")
	by ftp.linux-mips.org with SMTP id S20025147AbYG1ODV (ORCPT
	<rfc822;linux-mips@linux-mips.org>); Mon, 28 Jul 2008 15:03:21 +0100
Received: from localhost (p3065-ipad303funabasi.chiba.ocn.ne.jp [123.217.149.65])
	by smtp.mba.ocn.ne.jp (Postfix) with ESMTP
	id DCAC5AA6F; Mon, 28 Jul 2008 23:03:15 +0900 (JST)
Date: 	Mon, 28 Jul 2008 23:05:12 +0900 (JST)
Message-Id: <20080728.230512.132304415.anemo@mba.ocn.ne.jp>
To: jason.wessel@windriver.com
Cc: linux-kernel@vger.kernel.org, ralf@linux-mips.org,
        linux-mips@linux-mips.org
Subject: Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb
 core
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <20080725.235233.130241768.anemo@mba.ocn.ne.jp>
References: <20080725.012748.108121457.anemo@mba.ocn.ne.jp>
	<488941C5.9060908@windriver.com>
	<20080725.235233.130241768.anemo@mba.ocn.ne.jp>
X-Fingerprint: 6ACA 1623 39BD 9A94 9B1A  B746 CA77 FE94 2874 D52F
X-Pgp-Public-Key: http://wwwkeys.pgp.net/pks/lookup?op=get&search=0x2874D52F
X-Mailer: Mew version 5.2 on Emacs 21.4 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-archive-position: 19990
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: anemo@mba.ocn.ne.jp
Precedence: bulk
X-list: 	linux-mips
X-MessageOne-Virus-Version: vendor=fsecure engine=4.65.7161:2.4.4,1.2.40,4.0.164 definitions=2008-07-28_05:2008-07-24,2008-07-28,2008-07-28 signatures=0
X-MessageOne-Virus-Scanned: Clean
X-MessageOne-Envelope-Sender: linux-mips-bounce@linux-mips.org
X-MessageOne-Spam-Details: rule=m773emszm_notspam policy=m773emszm score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=3.1.0-0805090000 definitions=main-0807280054
X-MessageOne-Spam-Score: 0
X-MessageOne-Spam-Bar: 
Return-Path: linux-mips-bounce@linux-mips.org
X-OriginalArrivalTime: 28 Jul 2008 14:04:22.0221 (UTC) FILETIME=[D5D5EFD0:01C8F0BA]

On Fri, 25 Jul 2008 23:52:33 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> > It seem ok to me to try it.  Here is version 3 of the patch, which I was going to send to Ralf.
> 
> Thanks, it works for me with serial_txx9 kgdboc module.

BTW, is FRAME_POINTER mandatory for kgdb?  I agree that FRAME_POINTER
(ie. -fno-omit-frame-pointer -fno-optimize-sibling-calls) helps source
level debugging, but I think transparency is more important.

Now kgdboc can be loaded/activated at run-time, so I want to enable
CONFIG_KGDB usually.  But CONFIG_FRAME_POINTER introduces runtime
overhead on overall kernel, which is too bad (at least on MIPS).

Also, selecting FRAME_POINTER (which is not selectable on MIPS)
unconditionally looks somewhat inconsistent.

So ... Is this patch reasonable?


Subject: kgdb: Do not select FRAME_POINTER on MIPS

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/lib/Kconfig.kgdb b/lib/Kconfig.kgdb
index a5d4b1d..cc61bf0 100644
--- a/lib/Kconfig.kgdb
+++ b/lib/Kconfig.kgdb
@@ -7,7 +7,7 @@ config HAVE_ARCH_KGDB
 
 menuconfig KGDB
 	bool "KGDB: kernel debugging with remote gdb"
-	select FRAME_POINTER
+	select FRAME_POINTER if !MIPS
 	depends on HAVE_ARCH_KGDB
 	depends on DEBUG_KERNEL && EXPERIMENTAL
 	help

