Received: from mail.onstor.com ([66.201.51.107]) by onstor-exch02.onstor.net with Microsoft SMTPSVC(6.0.3790.1830);
	 Thu, 21 Aug 2008 15:17:07 -0700
Received: from ausesmta2-3.messageone.com ([64.20.241.45]) by mail.onstor.com with Microsoft SMTPSVC(6.0.3790.1830);
	 Thu, 21 Aug 2008 15:17:07 -0700
Received: from ftp.linux-mips.org (ftp.linux-mips.org [213.58.128.207])
	by ausesmta2-3.messageone.com (8.13.8/8.13.8) with ESMTP id m7LMH5kf032708
	for <andy.sharp@onstor.com>; Thu, 21 Aug 2008 17:17:06 -0500
Received: from localhost.localdomain ([127.0.0.1]:20659 "EHLO
	ftp.linux-mips.org") by ftp.linux-mips.org with ESMTP
	id S28587066AbYHUWQx (ORCPT <rfc822;andy.sharp@onstor.com>);
	Thu, 21 Aug 2008 23:16:53 +0100
Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 21 Aug 2008 23:16:37 +0100 (BST)
Received: from smtp4.int-evry.fr ([157.159.10.71]:17859 "EHLO
	smtp4.int-evry.fr") by ftp.linux-mips.org with ESMTP
	id S28587002AbYHUWPk (ORCPT <rfc822;linux-mips@linux-mips.org>);
	Thu, 21 Aug 2008 23:15:40 +0100
Received: from smtp2.int-evry.fr (smtp2.int-evry.fr [157.159.10.45])
	by smtp4.int-evry.fr (Postfix) with ESMTP id 5C21AFE2E23;
	Fri, 22 Aug 2008 00:15:39 +0200 (CEST)
Received: from smtp-ext.int-evry.fr (smtp-ext.int-evry.fr [157.159.11.17])
	by smtp2.int-evry.fr (Postfix) with ESMTP id 6E7453F00B2;
	Fri, 22 Aug 2008 00:15:03 +0200 (CEST)
Received: from lenovo.mimichou.home (florian.mimichou.net [82.241.112.26])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp-ext.int-evry.fr (Postfix) with ESMTP id 490C790004;
	Fri, 22 Aug 2008 00:15:03 +0200 (CEST)
From: Florian Fainelli <florian@openwrt.org>
Date: 	Fri, 22 Aug 2008 00:15:01 +0200
Subject: [PATCH 5/6] rb532: replace volatile rough read with a readl
MIME-Version: 1.0
X-UID: 	1121
X-Length: 1366
To: "linux-mips" <linux-mips@linux-mips.org>
Cc: ralf@linux-mips.org
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200808220015.02151.florian@openwrt.org>
X-INT-MailScanner-Information: Please contact the ISP for more information
X-MailScanner-ID: 6E7453F00B2.6BE60
X-INT-MailScanner: Found to be clean
X-INT-MailScanner-SpamCheck: 
X-INT-MailScanner-From: 	florian@openwrt.org
X-archive-position: 20314
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: florian@openwrt.org
Precedence: bulk
X-list: 	linux-mips
X-MessageOne-Virus-Version: vendor=fsecure engine=4.65.7161:2.4.4,1.2.40,4.0.164 definitions=2008-08-21_08:2008-08-21,2008-08-21,2008-08-21 signatures=0
X-MessageOne-Virus-Scanned: Clean
X-MessageOne-Envelope-Sender: linux-mips-bounce@linux-mips.org
X-MessageOne-Spam-Details: rule=m773emszm_notspam policy=m773emszm score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=3.1.0-0805090000 definitions=main-0808210180
X-MessageOne-Spam-Score: 0
X-MessageOne-Spam-Bar: 
Return-Path: linux-mips-bounce@linux-mips.org
X-OriginalArrivalTime: 21 Aug 2008 22:17:07.0782 (UTC) FILETIME=[A6328660:01C903DB]

This patch replaces a rough read using volatiles
with a readl.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c
index 3d1632c..d44a703 100644
--- a/arch/mips/rb532/gpio.c
+++ b/arch/mips/rb532/gpio.c
@@ -70,7 +70,7 @@ void set_434_reg(unsigned reg_offs, unsigned bit, unsigned len, unsigned val)
 
 	spin_lock_irqsave(&dev3.lock, flags);
 
-	data = *(volatile unsigned *) (IDT434_REG_BASE + reg_offs);
+	data = readl(IDT434_REG_BASE + reg_offs);
 	for (i = 0; i != len; ++i) {
 		if (val & (1 << i))
 			data |= (1 << (i + bit));

