Received: from mail.onstor.com (66.201.51.107) by exch1.onstor.net
 (10.0.0.225) with Microsoft SMTP Server id 8.1.311.2; Mon, 19 Jan 2009
 14:44:24 -0800
Received: from dalesmta2-3.messageone.com ([129.41.169.249]) by
 mail.onstor.com with Microsoft SMTPSVC(6.0.3790.3959);	 Mon, 19 Jan 2009
 14:44:17 -0800
Received: from ftp.linux-mips.org (ftp.linux-mips.org [213.58.128.207])	by
 dalesmta2-3.messageone.com (8.13.8/8.13.8) with ESMTP id n0JMiFex030391	for
 <andy.sharp@onstor.com>; Mon, 19 Jan 2009 16:44:17 -0600
Received: from localhost.localdomain ([127.0.0.1]:46552 "EHLO
	ftp.linux-mips.org") by ftp.linux-mips.org with ESMTP	id S21366174AbZASWoI
 (ORCPT <rfc822;andy.sharp@onstor.com>);	Mon, 19 Jan 2009 22:44:08 +0000
Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 19 Jan 2009 22:43:51
 +0000 (GMT)
Received: from orbit.nwl.cc ([91.121.169.95]:59617 "EHLO mail.nwl.cc")	by
 ftp.linux-mips.org with ESMTP id S21366187AbZASWnN (ORCPT
	<rfc822;linux-mips@linux-mips.org>); Mon, 19 Jan 2009 22:43:13 +0000
Received: from base (localhost [127.0.0.1])	by mail.nwl.cc (Postfix) with
 ESMTP id B8BF1400E125;	Mon, 19 Jan 2009 23:43:07 +0100 (CET)
From: Phil Sutter <n0-1@freewrt.org>
To: Linux-Mips List <linux-mips@linux-mips.org>
CC: "ralf@linux-mips.org" <ralf@linux-mips.org>, "florian@openwrt.org"
	<florian@openwrt.org>
Sender: "linux-mips-bounce@linux-mips.org" <linux-mips-bounce@linux-mips.org>
Date: Mon, 19 Jan 2009 14:42:51 -0800
Subject: [PATCH 2/5] MIPS: rb532: fix set_latch_u5()
Thread-Topic: [PATCH 2/5] MIPS: rb532: fix set_latch_u5()
Thread-Index: Acl6h3osGYIDvHxDTLutxtxBDACj2w==
Message-ID: <20090119224307.B8BF1400E125@mail.nwl.cc>
References: <1232404974-18497-1-git-send-email-n0-1@freewrt.org>
In-Reply-To: <1232404974-18497-1-git-send-email-n0-1@freewrt.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Exchange-Organization-AuthAs: Internal
X-MS-Exchange-Organization-AuthMechanism: 0b
X-MS-Exchange-Organization-AuthSource: exch1.onstor.net
X-MS-Has-Attach:
X-Auto-Response-Suppress: All
X-MS-TNEF-Correlator:
x-originalarrivaltime: 19 Jan 2009 22:44:17.0808 (UTC)
 FILETIME=[76250100:01C97A87]
errors-to: linux-mips-bounce@linux-mips.org
x-ems-proccessed: 2K3Xl1OQTInXD6xxuA8z3Q==
x-ems-stamp: /lhebhQhDyYg3gL1M7jxtQ==
x-messageone-virus-version: vendor=fsecure
 engine=4.65.7400:2.4.4,1.2.40,4.0.164
 definitions=2009-01-19_11:2009-01-18,2009-01-19,2009-01-19 signatures=0
x-messageone-virus-scanned: Clean
x-messageone-envelope-sender: linux-mips-bounce@linux-mips.org
x-messageone-spam-details: rule=m773emszm_notspam policy=m773emszm score=0
 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam
 adjust=0 reason=mlx engine=3.1.0-0810130000 definitions=main-0901190130
x-messageone-spam-score: 0
x-messageone-spam-bar:
x-list: linux-mips
x-archive-position: 21780
x-ecartis-version: Ecartis v1.0.0
x-original-sender: n0-1@freewrt.org
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

The data to be written is just a byte, so use writeb instead of writel.
Also, dev3.base contains the address, not the data so referencing here
is wrong.

Signed-off-by: Phil Sutter <n0-1@freewrt.org>
---
 arch/mips/rb532/gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c
index 40deb11..7e0cb4f 100644
--- a/arch/mips/rb532/gpio.c
+++ b/arch/mips/rb532/gpio.c
@@ -93,7 +93,7 @@ void set_latch_u5(unsigned char or_mask, unsigned char na=
nd_mask)
 	spin_lock_irqsave(&dev3.lock, flags);
=20
 	dev3.state =3D (dev3.state | or_mask) & ~nand_mask;
-	writel(dev3.state, &dev3.base);
+	writeb(dev3.state, dev3.base);
=20
 	spin_unlock_irqrestore(&dev3.lock, flags);
 }
--=20
1.5.6.4


