Received: from milmhbs1.lsil.com (147.145.21.209) by coscas01.lsi.com
 (172.21.36.60) with Microsoft SMTP Server id 8.1.393.1; Wed, 14 Oct 2009
 08:17:29 -0600
Received: from mail2.lsil.com (mail2.lsil.com [147.145.40.22])	by
 milmhbs1.lsil.com (8.12.11/8.12.11) with ESMTP id n9EEH6po005196	for
 <andy.sharp@lsi.com>; Wed, 14 Oct 2009 07:17:06 -0700
Received: from psmtp.com (na3sys009amx238.postini.com [74.125.149.122])	by
 mail2.lsil.com (8.12.11/8.12.11) with SMTP id n9EEDOVp022629	for
 <andy.sharp@lsi.com>; Wed, 14 Oct 2009 07:13:25 -0700 (PDT)
Received: from source ([122.28.14.163]) by na3sys009amx238.postini.com
 ([74.125.148.14]) with SMTP;	Wed, 14 Oct 2009 10:17:03 EDT
Received: from localhost.localdomain (p8042-ipad301funabasi.chiba.ocn.ne.jp
 [122.18.2.42])	by smtp.mba.ocn.ne.jp (Postfix) with ESMTP	id 329B66CE3; Wed,
 14 Oct 2009 23:17:00 +0900 (JST)
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
CC: "Sharp, Andy" <Andy.Sharp@lsi.com>, Thomas Hommel
	<thomas.hommel@gefanuc.com>, "rtc-linux@googlegroups.com"
	<rtc-linux@googlegroups.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "akpm@linux-foundation.org"
	<akpm@linux-foundation.org>
Date: Wed, 14 Oct 2009 08:17:01 -0600
Subject: [PATCH] rtc: Do not use container_of macro as an argument for
 to_platform_device
Thread-Topic: [PATCH] rtc: Do not use container_of macro as an argument for
 to_platform_device
Thread-Index: AcpM2RIQx/B2a1G/SDe/5PX1M372fA==
Message-ID: <1255529821-1377-1-git-send-email-anemo@mba.ocn.ne.jp>
Accept-Language: en-US
Content-Language: en-US
X-MS-Exchange-Organization-AuthAs: Anonymous
X-MS-Exchange-Organization-AuthSource: coscas01.lsi.com
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-scanned-by: MIMEDefang 2.39
x-pstn-levels: (S:34.35736/99.90000 CV:99.9000 FC:95.5390 LC:95.5390
 R:95.9108 P:95.9108 M:97.0282 C:98.6951 )
x-pstn-settings: 3 (1.0000:1.0000) s cv gt3 gt2 gt1 r p m c 
x-pstn-addresses: from <anemo@mba.ocn.ne.jp> [db-null] 
x-pstn-neptune: 0/0/0.00/0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

The to_platform_device macro itself uses container_of macro.
Nested use of container_of macro causes following sparse warnings:

rtc-ds1553.c:259:3: warning: symbol '__mptr' shadows an earlier one
rtc-ds1553.c:259:3: originally declared here

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
 drivers/rtc/rtc-ds1553.c   |    8 ++++----
 drivers/rtc/rtc-ds1742.c   |    8 ++++----
 drivers/rtc/rtc-stk17ta8.c |    8 ++++----
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/rtc/rtc-ds1553.c b/drivers/rtc/rtc-ds1553.c
index dadd0f5..ed1ef7c 100644
--- a/drivers/rtc/rtc-ds1553.c
+++ b/drivers/rtc/rtc-ds1553.c
@@ -255,8 +255,8 @@ static ssize_t ds1553_nvram_read(struct kobject *kobj,
 				 struct bin_attribute *bin_attr,
 				 char *buf, loff_t pos, size_t size)
 {
-	struct platform_device *pdev =3D
-		to_platform_device(container_of(kobj, struct device, kobj));
+	struct device *dev =3D container_of(kobj, struct device, kobj);
+	struct platform_device *pdev =3D to_platform_device(dev);
 	struct rtc_plat_data *pdata =3D platform_get_drvdata(pdev);
 	void __iomem *ioaddr =3D pdata->ioaddr;
 	ssize_t count;
@@ -270,8 +270,8 @@ static ssize_t ds1553_nvram_write(struct kobject *kobj,
 				  struct bin_attribute *bin_attr,
 				  char *buf, loff_t pos, size_t size)
 {
-	struct platform_device *pdev =3D
-		to_platform_device(container_of(kobj, struct device, kobj));
+	struct device *dev =3D container_of(kobj, struct device, kobj);
+	struct platform_device *pdev =3D to_platform_device(dev);
 	struct rtc_plat_data *pdata =3D platform_get_drvdata(pdev);
 	void __iomem *ioaddr =3D pdata->ioaddr;
 	ssize_t count;
diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c
index 19d2f33..a127336 100644
--- a/drivers/rtc/rtc-ds1742.c
+++ b/drivers/rtc/rtc-ds1742.c
@@ -131,8 +131,8 @@ static ssize_t ds1742_nvram_read(struct kobject *kobj,
 				 struct bin_attribute *bin_attr,
 				 char *buf, loff_t pos, size_t size)
 {
-	struct platform_device *pdev =3D
-		to_platform_device(container_of(kobj, struct device, kobj));
+	struct device *dev =3D container_of(kobj, struct device, kobj);
+	struct platform_device *pdev =3D to_platform_device(dev);
 	struct rtc_plat_data *pdata =3D platform_get_drvdata(pdev);
 	void __iomem *ioaddr =3D pdata->ioaddr_nvram;
 	ssize_t count;
@@ -146,8 +146,8 @@ static ssize_t ds1742_nvram_write(struct kobject *kobj,
 				  struct bin_attribute *bin_attr,
 				  char *buf, loff_t pos, size_t size)
 {
-	struct platform_device *pdev =3D
-		to_platform_device(container_of(kobj, struct device, kobj));
+	struct device *dev =3D container_of(kobj, struct device, kobj);
+	struct platform_device *pdev =3D to_platform_device(dev);
 	struct rtc_plat_data *pdata =3D platform_get_drvdata(pdev);
 	void __iomem *ioaddr =3D pdata->ioaddr_nvram;
 	ssize_t count;
diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c
index df3b6c5..eb486ca 100644
--- a/drivers/rtc/rtc-stk17ta8.c
+++ b/drivers/rtc/rtc-stk17ta8.c
@@ -247,8 +247,8 @@ static ssize_t stk17ta8_nvram_read(struct kobject *kobj=
,
 				 struct bin_attribute *attr, char *buf,
 				 loff_t pos, size_t size)
 {
-	struct platform_device *pdev =3D
-		to_platform_device(container_of(kobj, struct device, kobj));
+	struct device *dev =3D container_of(kobj, struct device, kobj);
+	struct platform_device *pdev =3D to_platform_device(dev);
 	struct rtc_plat_data *pdata =3D platform_get_drvdata(pdev);
 	void __iomem *ioaddr =3D pdata->ioaddr;
 	ssize_t count;
@@ -262,8 +262,8 @@ static ssize_t stk17ta8_nvram_write(struct kobject *kob=
j,
 				  struct bin_attribute *attr, char *buf,
 				  loff_t pos, size_t size)
 {
-	struct platform_device *pdev =3D
-		to_platform_device(container_of(kobj, struct device, kobj));
+	struct device *dev =3D container_of(kobj, struct device, kobj);
+	struct platform_device *pdev =3D to_platform_device(dev);
 	struct rtc_plat_data *pdata =3D platform_get_drvdata(pdev);
 	void __iomem *ioaddr =3D pdata->ioaddr;
 	ssize_t count;
--=20
1.5.6.5

