AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070727180738.5c302b7e@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E04AFA243@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 27 Jul 2007 18:07:43 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070727180743.2fedd83d@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E04AFA243@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E04AFA1BD@onstor-exch02.onstor.net>
	<20070725124634.3cb7ad81@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E04AFA243@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 25 Jul 2007 13:31:08 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Wednesday, July 25, 2007 12:47 PM
> >To: Maxim Kozlovsky
> >Subject: Re: Please review
> >
> >On Wed, 25 Jul 2007 12:02:17 -0700 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Change 24718 by maximk@maximk-5 on 2007/07/25 11:57:05 *pending*
> >>
> >>         Use the ip utility to add/delete the ip addresses.
> >>            Reviewed by andys.
> >>
> >> Affected files ...
> >>
> >> ... //depot/cougar/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c#1
> >> edit ... //depot/cougar/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.h#1
> >> edit
> >>
> >
> >nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c
> >
> >     what's wrong with the way it was being done, which didn't
> >     require adding an extra two packages, one of which we kinda
> >     don't want: libatm1 ?
> [MK] 
> It did not work and required a bunch of code which is identical to
> what the existing utility does. 
> 
> iproute does not require libatm1.

Huh?

$ apt-cache show iproute
Package: iproute
Priority: optional
Section: net
Installed-Size: 660
Maintainer: Alexander Wirt <formorer@debian.org>
Architecture: amd64
Version: 20061002-3
Provides: arpd
Depends: libatm1, libc6 (>= 2.3.5-1), libdb4.3 (>= 4.3.28-1)
Recommends: iproute-doc
Conflicts: arpd
.
.
.


> Ifconfig is kind of messed up that it does not have straightforward
> way to add/delete the ip addresses and has weirdness with treatment of
> "primary" ip address on the interface.
> 
> >
> >nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.h
> >
> >     see previous question
> 


OK, check it in.  I'll add it to bc-masses
