AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070801101718.7331f3e0@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<amit.bothra@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAIL9aWYqhwFKp4W00000f88@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 1 Aug 2007 10:17:29 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: amitb <amit.bothra@onstor.com>
Subject: Re: PERFORCE change 24795 for review
Message-ID: <20070801101729.6c23cc12@ripper.onstor.net>
In-Reply-To: <WEBMAIL9aWYqhwFKp4W00000f88@mail.onstor.com>
References: <WEBMAIL9aWYqhwFKp4W00000f88@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Amit,

I know you just started so no one has probably told you, but our
convention for code checkin comments is to have a lot more
information.  For example, 3 months from now if you went and looked at
the history of the file fs-log-replay.c and saw this comment, would you
know enough to determine if you needed to examine the change(s) more
closely?  Probably not, since "Coverity Fixes" doesn't really tell you
anything.  In general try to include more information, but don't spend
too much time on it.  Think of the checkin comments as a quick note you
are sending to yourself in the future to remind you what this change
was about.

Thanks,

a


On 31 Jul 2007 22:14:22 -0700 amitb <amit.bothra@onstor.com> wrote:

> Change 24795 by amitb@amitb-zonda on 2007/07/31 22:06:30
> 
> 	Coverity Fixes 
> 	Reviewed by jobia
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-fs/btree/emaproot.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-admin.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-am.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-api.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-buf.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-context.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-debug.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-dir.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-err.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-global.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-inode.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-log-replay.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-log.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-ref.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-trashcan.c#2 edit
> 
> 
> http://liszt:1818/@md=d&cd=//depot/$c=G35@/24795?ac=10
