AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E04D200F3@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 2 Aug 2007 14:42:27 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070802144227.44d81985@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E04D200F3@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E04D200F3@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 31 Jul 2007 14:47:45 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Change 24792 by maximk@maximk-5 on 2007/07/31 14:40:12 *pending*
> 
>            Set O_NONBLOCK properly.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-utils/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/sm-utils/sys-utils-api.h#1 add
> ... //depot/dev/nfx-tree/code/sm-utils/sys-utils.c#1 add
> ... //depot/dev/nfx-tree/code/ssc-authentication/auth-cifs.c#1 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxnis/nfxnis-lib.c#1 edit
> ... //depot/dev/nfx-tree/code/ssc-tests/anpssctest.c#1 edit


nfx-tree/code/sm-utils/Makefile

     looks good

nfx-tree/code/sm-utils/sys-utils-api.h

     >>add nfx-tree/code/sm-utils/sys-utils-api.h

     looks good

nfx-tree/code/sm-utils/sys-utils.c

     >>add nfx-tree/code/sm-utils/sys-utils.c

     looks good

nfx-tree/code/ssc-authentication/auth-cifs.c

     why bother to convert set_fd_block() to use the new api function
     if you are then just going to change all the places it was called
     to use the new api function?  can't you just remove set_fd_block()?

nfx-tree/code/ssc-nfxnis/nfxnis-lib.c

     looks good

nfx-tree/code/ssc-tests/anpssctest.c

     looks good

