AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E04DF971F@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 3 Aug 2007 19:14:27 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review .2
Message-ID: <20070803191427.086d485a@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E04DF971F@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E04DF9704@onstor-exch02.onstor.net>
	<20070802144254.06909a02@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E04DF971F@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 2 Aug 2007 14:45:31 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> 24820
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Thursday, August 02, 2007 2:43 PM
> >To: Maxim Kozlovsky
> >Subject: Re: Please review .2
> >
> >On Thu, 2 Aug 2007 14:32:20 -0700 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >>         nfxdns-gethostbyname nfxdns-gethostbyaddr implementation.
> >>            Reviewed by andys.
> >>
> >> Affected files ...
> >
> >can i get a cl#?


linux/src/glibc-2.3.6.ds1/glibc-2.3.6/Versions.def

     i have no idea what i'm looking at, but ok!

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/include/resolv.h

     hidden protos are always good (?)

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/linuxthreads/sysdeps/pthread/res-state.c

     hidden defs even better (??)

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nss/Versions

     excellent

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nss/nss_files/files-XXX.c

     i don't get it, this would seem to be a zero sum change.  do we
     replace the function with our own later?  i guess we do.  nice.

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/resolv/Versions

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/resolv/res_init.c

     looks good

nfx-tree/Includes/openbsd/nfxdns-inlines.h

     aiee, this file is in openbsd?  is it used in the linux build of
     the product?  won't the BSD build still need the locks?

nfx-tree/Makefile.ssc

     looks good

nfx-tree/code/sm-utils/cmd-utils.c

     looks good

nfx-tree/code/sm-utils/cmd-utils.h

     looks good

nfx-tree/code/ssc-nfxnis/nfxdns-api.h

     looks good

nfx-tree/code/ssc-nfxnis/nfxdns-internal.h

     >>add nfx-tree/code/ssc-nfxnis/nfxdns-internal.h

     trailing whitespace: 11-13

nfx-tree/code/ssc-nfxnis/nfxdns-linux.c

     line 28 why not use variable macro?
     #define debugger(x...) printf(x)
     then you can do things like this to add the function name and newline and stuff:
     #define debugu(fmt, args...) \
     	printf("%s: " fmt "\n", __func__, ##args)
     cpp automatically handles the case where there is only one argument

     line 125 (i think) "name - the database name."	???



nfx-tree/code/ssc-nfxnis/nfxdns-openbsd.c

     line 822, won't bsd need the locks anymore?

nfx-tree/code/ssc-nfxnis/nfxdns.c

     wow, this represents some good changes.  once again, zonda
     benefits from being tied to cougar.  unless it doesn't work,
     then we're all in big trouble ~:^)

nfx-tree/code/ssc-nfxsh/cmd_system.c

     looks good

nfx-tree/code/ssc-tests/Makefile

     looks good

nfx-tree/code/ssc-tests/nfxdnstest.c

     >>add nfx-tree/code/ssc-tests/nfxdnstest.c
     	nice

