AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E04EECE40@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 10 Aug 2007 11:42:57 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070810114257.52a522db@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E04EECE40@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E04EECE40@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 10 Aug 2007 11:15:30 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Change 24982 by maximk@maximk-5 on 2007/08/10 11:10:24 *pending*
> 
>         Fix adding of non-default routes.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/eee.h#1 add
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/ipmd-lib-linux.c#1 add
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/ipmd-lib-openbsd.c#1 add
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/ipmd-lib.c#1 edit
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/ipmd-lib.h#1 edit
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/linux.h#1 add
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/openbsd.h#1 add
> ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd.c#1 edit
> ... //depot/dev/nfx-tree/code/ssc-tests/Makefile#3 edit
> ... //depot/dev/nfx-tree/code/ssc-tests/ipmdlibtest-linux.c#1 add
> ... //depot/dev/nfx-tree/code/ssc-tests/ipmdlibtest-openbsd.c#1 add

nfx-tree/code/sm-ipmd-lib/Makefile

     looks good

nfx-tree/code/sm-ipmd-lib/eee.h

     >>add nfx-tree/code/sm-ipmd-lib/eee.h

     ok

nfx-tree/code/sm-ipmd-lib/ipmd-lib-linux.c

     >>add nfx-tree/code/sm-ipmd-lib/ipmd-lib-linux.c

     trailing whitespace, please fix your editor program to not be
     retarded.  lines 37, 39, 65, 72

nfx-tree/code/sm-ipmd-lib/ipmd-lib-openbsd.c

     >>add nfx-tree/code/sm-ipmd-lib/ipmd-lib-openbsd.c

     fix trailing whitespace all over the place

nfx-tree/code/sm-ipmd-lib/ipmd-lib.c

     geez, can't you fix the broken trailing whitespace in your
     editor program?

     line 2238, the use of truncate here troubles me.  i'd at least
     like to see another rewind(fp) first.  i'm afraid that a truncate()
     here could cause a sparse file because the offset in fp isn't being
     reset, so the fwrite would start writing at the current offset.

nfx-tree/code/sm-ipmd-lib/ipmd-lib.h

     looks good

nfx-tree/code/sm-ipmd-lib/linux.h

     >>add nfx-tree/code/sm-ipmd-lib/linux.h

     ok

nfx-tree/code/sm-ipmd-lib/openbsd.h

     >>add nfx-tree/code/sm-ipmd-lib/openbsd.h

     ok

nfx-tree/code/sm-ipmd/ipmd.c

     looks good

nfx-tree/code/ssc-tests/Makefile

     looks good

nfx-tree/code/ssc-tests/ipmdlibtest-linux.c

     >>add nfx-tree/code/ssc-tests/ipmdlibtest-linux.c

     good

nfx-tree/code/ssc-tests/ipmdlibtest-openbsd.c

     >>add nfx-tree/code/ssc-tests/ipmdlibtest-openbsd.c

     ok

