AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070814165912.25065ce5@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E04FA7F21@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 14 Aug 2007 17:00:09 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070814170009.54753a56@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E04FA7F21@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E04FA7EB9@onstor-exch02.onstor.net>
	<20070814165346.01b32db8@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E04FA7F21@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 14 Aug 2007 16:55:59 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> 
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Tuesday, August 14, 2007 4:54 PM
> >To: Maxim Kozlovsky
> >Subject: Re: Please review
> >
> >On Tue, 14 Aug 2007 15:59:54 -0700 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Change 25018 by maximk@maximk-13 on 2007/08/14 15:55:01 *pending*
> >>
> >>         fix unsigned/signed mismatch
> >>            Reviewed by andys.
> >>
> >> Affected files ...
> >>
> >> ... //depot/dev/nfx-tree/code/sm-utils/sys-utils-linux.c#1 edit
> >>
> >
> >yeesh, ugly.  can't you just make line 28
> >
> >unsigned long
> >
> >instead of long?
> [MK] 
> This will not help and original gethostid() returns long.

how about

return ((ifr.ifr_hwaddr.sa_data[3] & 0xff) << 8) | (ifr.ifr_hwaddr.sa_data[4] & 0xff);

at least that way you don't have 400 parens and no readability.
