AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0507D6D2@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 15 Aug 2007 15:49:28 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070815154928.100d6064@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0507D6D2@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0507D6D2@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 15 Aug 2007 15:38:07 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> What about this one?
> 
> _____________________________________________
> From: Maxim Kozlovsky 
> Sent: Wednesday, August 15, 2007 12:00 PM
> To: Andy Sharp
> Subject: Please review
> 
> Change 25026 by maximk@maximk-5 on 2007/08/15 11:52:18 *pending*
> 
>         fix ntp configuration for linux.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/Makefile#1 edit
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/linux.h#1 add
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp.conf.template#1
> delete ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp.conf.template.linux#1
> add
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp.conf.template.openbsd#1
> branch
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils-linux.c#1 add
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils-openbsd.c#1 add
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils.c#1 edit
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/openbsd.h#1 add


nfx-tree/code/ssc-timekeeper/Makefile

     looks good

nfx-tree/code/ssc-timekeeper/linux.h

     >>add nfx-tree/code/ssc-timekeeper/linux.h

     good

nfx-tree/code/ssc-timekeeper/ntp.conf.template

     >>delete nfx-tree/code/ssc-timekeeper/ntp.conf.template

     good

nfx-tree/code/ssc-timekeeper/ntp.conf.template.linux

     >>add nfx-tree/code/ssc-timekeeper/ntp.conf.template.linux

     trailing ws line 2

nfx-tree/code/ssc-timekeeper/ntp_utils-linux.c

     >>add nfx-tree/code/ssc-timekeeper/ntp_utils-linux.c

     good

nfx-tree/code/ssc-timekeeper/ntp_utils-openbsd.c

     >>add nfx-tree/code/ssc-timekeeper/ntp_utils-openbsd.c

     good

nfx-tree/code/ssc-timekeeper/ntp_utils.c

     while here, fix the crap on lines 109/110

     otherwise looks good

nfx-tree/code/ssc-timekeeper/openbsd.h

     >>add nfx-tree/code/ssc-timekeeper/openbsd.h

     good

