AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070816105658.5cfb6327@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0507D9E9@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 16 Aug 2007 10:57:05 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070816105705.69bcdc22@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0507D9E9@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0507D9A7@onstor-exch02.onstor.net>
	<20070816104251.29ee41f2@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0507D9E9@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 16 Aug 2007 10:46:40 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Thursday, August 16, 2007 10:43 AM
> >To: Maxim Kozlovsky
> >Subject: Re: Please review
> >
> >On Thu, 16 Aug 2007 10:17:10 -0700 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Change 25046 by maximk@maximk-5 on 2007/08/16 10:11:55 *pending*
> >>
> >>            fix interface commands for linux.
> >>            Reviewed by andys.
> >>
> >> Affected files ...
> >>
> >> ... //depot/dev/nfx-tree/Includes/eee/ipm-if.h#1 add
> >> ... //depot/dev/nfx-tree/Includes/nfx-ports.h#1 edit
> >> ... //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c#2 edit
> >
> >nfx-tree/Includes/eee/ipm-if.h
> >
> >     >>add nfx-tree/Includes/eee/ipm-if.h
> >
> >     sc?  can't we switch to a meaningful name?  how about mgmt?
> > mgt?
> [MK] 
> I suppose we could, but it is not that easy (the upgrade may be
> tricky) and is out of scope of the current project. At least during
> the cougar work we will get all references in the code to be done
> through #defines instead of direct strings. Can you live with your
> hate for a while?

Nice.  No, I'm not living with hate, I'm living with love.  Love to get
the OS specific device names out of the customer interface.  I hope
you're not offended by that.

> >
> >     i hate sc.  i would use eth, but that's also a little too system
> >     specific.
> >
> >     what do you think?  i'd love to get these openbsd device names
> > out of our system, out of our GUI interface, etc.
> >
> >nfx-tree/Includes/nfx-ports.h
> >
> >     looks good
> >
> >nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c
> >
> >     looks good
> 
