AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070105143059.17afd2f4@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0A9455@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 5 Jan 2007 14:32:10 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Code review for rc.agile
Message-ID: <20070105143210.33ac57ec@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0A9455@onstor-exch02.onstor.net>
References: <20070105141634.7ee8a29a@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0A9455@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 5 Jan 2007 14:20:12 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I am building an image to test as I type!
> 
>  
> 
> Thanks for the review. This is what the script looks like with your
> suggestions incoporated:
> 
>  
> 
> # New Zoneinfo file for DST upgrades installed once at boot time
> 
> if [ -f /var/tmp/zoneinfo.tgz ] ; then
> 
>    mount -u -w `df /usr | fgrep /usr | awk '{print $NF}'`

won't work on systems where /usr isn't separately mounted.  try:

df /usr | tail -1 | awk '{print $NF}'

>    tar zxpf /var/tmp/zoneinfo.tgz -C /
> 
>    if [ -f /usr/share/zoneinfo/America/Kentucky/Louisville ] ; then
> 
>       rm -f /var/tmp/zoneinfo.tgz
> 
>       echo "New Time Zone Files for Daylight Savings Time (DST)
> Installed"
> 
>    fi
> 
>    mount -u -o ro `df /usr | fgrep /usr | awk '{print $NF}'`
> 
> fi
> 
>  
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@onstor.com] 
> Sent: Friday, January 05, 2007 2:17 PM
> To: Larry Scheer
> Subject: Re: Code review for rc.agile
> 
>  
> 
> On Fri, 5 Jan 2007 11:51:32 -0800 Andrew Sharp <andy.sharp@onstor.com>
> 
> wrote:
> 
>  
> 
> > Basically, it looks OK.
> 
> > 
> 
> > On Thu, 4 Jan 2007 19:24:29 -0800 "Larry Scheer"
> 
> > <larry.scheer@onstor.com> wrote:
> 
> > 
> 
> > > Andy,
> 
> > >     Here are my changes to implement the fix for the missing
> 
> > > timezone files: 
> 
> > > 
> 
> > > Added to the release target in nfx-tree/Makefile the script to
> > > build
> 
> > > the tar file  for zoneinfo
> 
> > > 
> 
> > > > # Upgrade is mis-handling zoneinfo files here is part of the
> 
> > > work-around until
> 
> > > > # upgrade is fixed
> 
> > > >       cd ${PATH_TO_RELEASE} && \
> 
> > > >       $(SUDO) tar zcvf var/zoneinfo.tgz ./usr/share/zoneinfo
> 
> > 
> 
> > Please change the tar file to /var/tmp/zoneinfo.tgz
> 
> > Don't put things in the top level of /var
> 
>  
> 
> Based on what I can see in cmd_upgrade.c, there should be no problem
> 
> putting this file in /var/tmp.  It will be treated as a new file and
> 
> copied onto the system.  Obviously you need to test all this.
> 
>  
> 
> > > The changes to rc.agile:
> 
> > > 
> 
> > > p4 diff rc.agile
> 
> > > ==== //depot/FB-LAMBORGHINI/nfx-tree/code/ssc-pm/rc.agile#3 -
> 
> > >
> /home/larrys/perforce/trees/FB-LAMBORGHINI/nfx-tree/code/ssc-pm/rc.agile
> 
> > > ====
> 
> > > 27c27,38
> 
> > > < 
> 
> > > ---
> 
> > > > 
> 
> > > > # New Zoneinfo file for DST upgrades installed once at boot time
> 
> > > > if [ -f /var/zoneinfo.tgz ] ; then
> 
> > 
> 
> > /var/tmp/zoninfo.tgz
> 
> > 
> 
> > > >    mount -u /usr
> 
> > 
> 
> > mount -u -w /usr
> 
> > 
> 
> > Don't assume that /usr is separately mounted.  Check first to see
> > what
> 
> > filesystem /usr is on, and do the remounting on that filesystem.
> 
> > 
> 
> > > >    tar zxpf /var/zoneinfo.tgz -C /
> 
> > 
> 
> > /var/tmp
> 
> > 
> 
> > > >    if [ -f /usr/share/zoneinfo/America/Kentucky/Louisville ] ;
> 
> > > > then rm -f /var/zoneinfo.tgz  
> 
> > > >       echo "New Time Zone Files for Daylight Savings Time (DST)
> 
> > > Installed"
> 
> > > >    fi
> 
> > 
> 
> > I suppose this specific check is OK for now ... probably not really
> 
> > necessary, however.
> 
> > 
> 
> > > >    mount -u -o ro /usr
> 
> > 
> 
> > Again, remount the filesystem that has /usr on it, not just
> 
> > assuming /usr is a separate mount.
> 
> > 
> 
> > > > fi
> 
> > > >
> 
> > > 
> 
> > > The install places the zoneinfo tar file in the /var directory. At
> 
> > > boot time if the tar file exists it gets untarred into /usr. The
> 
> > > check for success is to verify just one (out of many files) of the
> 
> > > new files is there, if it is the tar file is removed and  this
> 
> > > segment of the script is never run until the next upgrade places
> > > the
> 
> > > tar file back in /var.
> 
> > > 
> 
> > > Do you think this is sufficient? Any comments?
> 
> > 
> 
> > Looks good.
> 
> > 
> 
> > Cheers,
> 
> > 
> 
> > a
> 
