AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070816170127.39f5e276@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0507DBDF@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 16 Aug 2007 17:01:37 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070816170137.1bd2438d@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0507DBDF@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0507DBDF@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 16 Aug 2007 16:06:40 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Change 25052 by maximk@maximk-5 on 2007/08/16 14:15:35 *pending*
> 
>         Move common code into a library.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-ea/ea-cfgd.c#1 edit
> ... //depot/dev/nfx-tree/code/sm-ea/ea-util.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-ea/ea-util.h#4 edit
> ... //depot/dev/nfx-tree/code/sm-evm/evm-cfgd.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-evm/evm-util.c#1 edit
> ... //depot/dev/nfx-tree/code/sm-evm/evm-util.h#1 edit
> ... //depot/dev/nfx-tree/code/sm-utils/Makefile#3 edit
> ... //depot/dev/nfx-tree/code/sm-utils/chassis-utils-api.h#1 add
> ... //depot/dev/nfx-tree/code/sm-utils/chassis-utils.c#1 add
> ... //depot/dev/nfx-tree/code/ssc-ndmp/ndmp-main.c#1 edit
> ... //depot/dev/nfx-tree/code/ssc-tests/Makefile#4 edit
> ... //depot/dev/nfx-tree/code/ssc-tests/utilstest.c#1 add
> ... //depot/dev/nfx-tree/code/ssc-vsd/vs-daemon.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-vsd/vs-util.c#1 edit
> ... //depot/dev/nfx-tree/code/ssc-vsd/vs-util.h#1 edit
> ... //depot/dev/nfx-tree/code/ssc-vtm/vtm-msg.c#1 edit
> 
> 
> Change 25055 by maximk@maximk-5 on 2007/08/16 15:59:18 *pending*
> 
>         Replace unnecessary specialization from fp1 to fp_any.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-event/event.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-timer/timer-tic.c#1 edit
> ... //depot/dev/nfx-tree/code/sm-utils/cmd-utils.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cluster.c#1 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_stats.c#1 edit


Nice one, Max.  It all looks good.


nfx-tree/code/sm-ea/ea-cfgd.c

     looks good

nfx-tree/code/sm-ea/ea-util.c

     looks good

nfx-tree/code/sm-ea/ea-util.h

     looks good

nfx-tree/code/sm-evm/evm-cfgd.c

     looks good

nfx-tree/code/sm-evm/evm-util.c

     looks good

nfx-tree/code/sm-evm/evm-util.h

     looks good

nfx-tree/code/sm-utils/Makefile

     looks good

nfx-tree/code/sm-utils/chassis-utils-api.h

     >>add nfx-tree/code/sm-utils/chassis-utils-api.h

nfx-tree/code/sm-utils/chassis-utils.c

     >>add nfx-tree/code/sm-utils/chassis-utils.c

nfx-tree/code/ssc-ndmp/ndmp-main.c

     looks good

nfx-tree/code/ssc-tests/Makefile

     looks good

nfx-tree/code/ssc-tests/utilstest.c

     >>add nfx-tree/code/ssc-tests/utilstest.c

nfx-tree/code/ssc-vsd/vs-daemon.c

     looks good

nfx-tree/code/ssc-vsd/vs-util.c

     looks good

nfx-tree/code/ssc-vsd/vs-util.h

     looks good

nfx-tree/code/ssc-vtm/vtm-msg.c

     looks good




nfx-tree/code/sm-event/event.c

     looks good

nfx-tree/code/sm-timer/timer-tic.c

     looks good

nfx-tree/code/sm-utils/cmd-utils.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_cluster.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_stats.c

     looks good

