AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070817143156.102e9716@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0221598D@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 17 Aug 2007 14:32:03 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Review request
Message-ID: <20070817143203.5a69b364@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221598D@onstor-exch02.onstor.net>
References: <20070817141600.19a76884@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0221598D@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 17 Aug 2007 14:20:29 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Ok I will remove fstab.sav from the list of files to add.
> For convenience would you mind if I conditionally use/reference it in
> the Makefile and rcS? My thinking here is if I find it useful others
> will, too.

Delete dead code.  Besides, what did you find it useful for?

> -----Original Message-----
> From: Andy Sharp 
> Sent: Friday, August 17, 2007 2:16 PM
> To: Larry Scheer
> Subject: Re: Review request
> 
> On Fri, 17 Aug 2007 14:06:51 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > I am still working on the Makefile I need to add pmtab to the
> > rootfs. And I still need to verify rcS is correct. 
> > My workspace is: ~larrys/src/dev
> 
> Since there's bound to be things changed after you test again, go
> ahead and do that first.
> 
> > Change 25072 by larrys@larrys on 2007/08/17 13:58:54 *pending*
> > 
> >         Makefile to create the Linux Root Filesystem.
> >         Additional files needed to run debootstrap --second-stage
> > and to get initial login and boot to work.
> >         Note: some of this inital work is specific to using an NFS
> > root filesystem in our lab environment. 
> >         Reviewed by: andys
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/rootfs/Makefile#1 add
> > ... //depot/dev/linux/rootfs/etc/fstab.sav#1 add
> 
> I don't think we need this.
> 
> > ... //depot/dev/linux/rootfs/etc/init.d/rcS#1 add
> > ... //depot/dev/linux/rootfs/etc/inittab#1 add
> > ... //depot/dev/linux/rootfs/etc/securetty#1 add
> > ... //depot/dev/linux/rootfs/etc/yp.conf#1 add
