AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070822144557.17208b95@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E051AEC32@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 22 Aug 2007 14:46:39 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: pleeze review
Message-ID: <20070822144639.43699ebc@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E051AEC32@onstor-exch02.onstor.net>
References: <20070822133943.32a19c20@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E051AEC32@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 22 Aug 2007 14:02:51 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> 
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Wednesday, August 22, 2007 1:40 PM
> >To: Maxim Kozlovsky
> >Subject: pleeze review
> >
> >Change 25125 by andys@ripper on 2007/08/22 11:05:06 *pending*
> >
> >        Some kernel updates before cougar changes come in.
> >
> >        Add a touch of locking to the driver on the TX side; and some
> >        TX drain control to the mpsc console tx routine in an attempt
> >        to fix console lockup problem.  Might be helping, but console
> >        still locks up sometimes.
> >
> >        Make the ide-cs hacks more benign in regards to cougar which
> >        won't need them.
> >
> >Affected files ...
> >
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ide/legacy/ide-cs.c#2
> >edit
> [MK] 
> Ok
> 
> >... //depot/dev/linux/kernel/linux-mips-2.6/drivers/serial/mpsc.c#1
> edit
> [MK] 
> 554: why change, the registers are 4 byte wide.

this came from the 2.6.22 version of the driver.  i can only guess
something like this writes only to the byte that applies to the
specific port, rather than acking the interrupt for all ports?  the
user's guide doesn't specifically say how big the register is, just the
beginning offset.  at least, not that i could find.


> 1118,1221: I have no idea what low_latency means and why does it
> matter but ok.

code for tty_flip_buffer_push() says it should never be called if tty is
in low_latency mode.

> 1752: This is going to deadlock with itself.

i sure hope not.  the driver doesn't use interrupts when in "console"
mode; the idea is to flush any previously queued output (and interrupt
states) when console write is called.

> I am curious, why you are adding spinlock for tx but no spinlock for
> rx?

rx doesn't need it ~:^)  there is no console read method
