AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070822173244.7f983e2c@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E051AECAB@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 22 Aug 2007 17:33:08 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: pleeze review
Message-ID: <20070822173308.7dda14ac@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E051AECAB@onstor-exch02.onstor.net>
References: <20070822133943.32a19c20@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E051AEC32@onstor-exch02.onstor.net>
	<20070822144639.43699ebc@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E051AECAB@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 22 Aug 2007 14:49:59 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> >
> >> 1752: This is going to deadlock with itself.
> >
> >i sure hope not.  the driver doesn't use interrupts when in "console"
> >mode; the idea is to flush any previously queued output (and
> >interrupt states) when console write is called.
> [MK] 
> The code gets a spinlock, then calls mpsc_tx_intr(), which is going to
> try to get a spinlock again. How this will not deadlock?
> 
> 

sigh

ok, take a look at it now.

why am i bothering with this?  where is that magic 8 ball when i need
answers?