AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070829182921.79b67cde@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<danqing.jin@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E03AEAD20@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 29 Aug 2007 18:30:03 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Danqing Jin" <danqing.jin@onstor.com>
Subject: Re: Request for code review (for defect 20051)
Message-ID: <20070829183003.366c56c1@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E03AEAD20@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E03AEAD20@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Danqing,

Could you do me a favor and put the changes in their own changelist
number?  If you aren't familiar with how to do this, use the 'p4
change' command.

Thanks,

a

On Wed, 29 Aug 2007 17:28:41 -0700 "Danqing Jin"
<danqing.jin@onstor.com> wrote:

> Andy,
> 
> I know you must be busy with you own project, but because you are the
> well-recognized BSD/Linux kernel person, I have to bug you with this
> code review...
> 
> Defect 20051 reports silient reboots of our filer.  Support was able
> demostrate that silient reboot could effect under some stress
> condition such as low memory.  With some further experiments by
> simulating such low memory condition, I think this is likely coming
> from a reset from our watchdog (ds1511_restart_watchdog()) on SSC
> since for some unknown reason no one kicks the watchdog under such
> stress condition (even including  high CPU load or CPU thrashing).
> Now customer support would like us to give some clues for such
> silient reboots.  So I was thinking about logging to BSD syslog when
> things are getting quite bad:
> 
> 1. when there are only small number of free pages
> 2. when the cpu load is greater than some very high number
> 
> For item 1, I eventually arrive at 60 pages (i.e., 6 times of
> vm_page_free_reserved, which is 10 pages) after varying it between 20
> and 250 pages.  For item 2, I am not as sure as this number could be
> quite arbituary, and I am using 64 just to be not too chatty.  But
> hopefully you may have some insight on this...
> 
> Many thanks in advance,
> -Danqing-
> 
> P4 client:		danqingj-r301rel
> Changed files:
> /homes/danqingj/src/r301rel/openbsd/src/sys/vm/vm_meter.c
> 	
> /homes/danqingj/src/r301rel/openbsd/src/sys/vm/vm_page.c
