AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070907113840.6366793c@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<henry.lau@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAILdFEu5tnlHqIN00000cf4@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 7 Sep 2007 11:39:59 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: henryl <henry.lau@onstor.com>
Subject: Re: PERFORCE change 25298 for review
Message-ID: <20070907113959.64631f53@ripper.onstor.net>
In-Reply-To: <WEBMAILdFEu5tnlHqIN00000cf4@mail.onstor.com>
References: <WEBMAILdFEu5tnlHqIN00000cf4@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On 7 Sep 2007 10:34:44 -0700 henryl <henry.lau@onstor.com> wrote:

> Change 25298 by henryl@henryl-linux on 2007/09/07 10:26:38
> 
> 	   Various Coverity fixes.
> 	   Reviewed by AmitB.    
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-fs/fs-alloc.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-dump.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-layout.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-snap.c#12 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-trashcan.h#2 edit
> 
> 
> http://liszt:1818/@md=d&cd=//depot/$c=G35@/25298?ac=10

Hi Henry,

I hate to be the nudge here, but this checkin comment probably doesn't
really suffice to help you. 6 months from now if you were looking
through the changes for fs-snap.c and saw a change with this comment,
would you have any idea what the change to that file might be about?
Remeber that these comments are like messages in a bottle -- to
yourself in the future.  I would think something along the lines of
"fixed this, that and the other [type problems].  found by coverity."
would be more helpful to you.

Cheers,

a