AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070912132127.0c0f533e@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ken.renshaw@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0579D52E@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 12 Sep 2007 13:21:59 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ken Renshaw" <ken.renshaw@onstor.com>
Subject: Re: PERFORCE change 25364 for review
Message-ID: <20070912132159.73b8d32a@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0579D52E@onstor-exch02.onstor.net>
References: <20070912124941.6f99f2c0@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0579D52E@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I think it's safe to reject a checkin with either no or blank comment,
don't you?  I can't think of any reason why we would want to allow
that.  Unless some of the more essoteric branches allow that for some
reason.  Anyway it's got to be helpful too because it's almost certainly
a mistake, as I assume this one was. I'd be pretty thankful if I
accidentally did a submit with just a blank line for a comment and it
was rejected so I could get a second chance.

Cheers,

a

 On Wed, 12 Sep 2007 12:57:17 -0700 "Ken Renshaw"
<ken.renshaw@onstor.com> wrote:

> Yeah, I saw that too...he slipped it through since he noticed we
> filter on filetypes ( .c, .h., etc. etc. ). 
> 
> Would you like to see any and all checkins stopped at the gate then
> Andy?
> 
> 
> Thanks,
> 
> -Ken
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, September 12, 2007 12:50 PM
> To: Maxim Kozlovsky
> Cc: Ken Renshaw
> Subject: Re: PERFORCE change 25364 for review
> 
> Dude.
> 
> [Ken, can we add a commit trigger that doesn't accept checkins with
> no (or only whitespace) comment?]
> 
> a
> 
> On 12 Sep 2007 10:59:47 -0700 Maxim Kozlovsky
> <maxim.kozlovsky@onstor.com> wrote:
> 
> > Change 25364 by maximk@maximk-5 on 2007/09/12 10:54:47
> > 
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/kernel/linux-mips-2.6/bobcat-config#4 edit
> > 
> > 
> > http://liszt:1818/@md=d&cd=//depot/$c=G35@/25364?ac=10
