AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070924115843.24b327b2@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C90F4@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 24 Sep 2007 11:59:51 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Review request
Message-ID: <20070924115951.0265408d@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C90F4@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C90F4@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 20 Sep 2007 17:52:37 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> My workspace is /homes/larrys/src/dev
> 
> Change 25541 by larrys@larrys on 2007/09/20 17:08:25 *pending*
> 
>         New file: pkg-tools/mk-binary-repo is a script that creates a
>         debian repository that is capable of working with apt-get.
>         The control files Pkgs/conf/distributions and Pkgs/options
>         are additions that work with the program reprepro. (Don't ask
>         me how its pronounsed...) The script mk-binary-repo uses
>         reprepro to create the repository and add the debian packages
>         to the distribution pools.
> 
>         Updates to mk-mipsel-deb-rootfs to build the root file system
>         correctly and to use either a tar ball of all of the debian
>         packages or a URL to a debian distro. URL is set to file://
>         currently which works if you have distro created with
>         mk-binary-repo.
> 
>         Updated pkg-tools/mk-source-repo with packages added to
> rootfs. Reviewd by:
> 
> Affected files ...
> 
> ... //depot/dev/linux/Pkgs/conf/distributions#1 add
> ... //depot/dev/linux/Pkgs/options#1 add
> ... //depot/dev/linux/pkg-tools/mk-binary-repo#1 add
> ... //depot/dev/linux/pkg-tools/mk-mipsel-deb-rootfs#5 edit
> ... //depot/dev/linux/pkg-tools/mk-source-repo#4 edit


Ouch, this request completely disappeared off my radar screen, sorry.
If you hadn't mentioned it in your email, I would not have remembered
it.  My bad.


linux/Pkgs/conf/distributions

     >>add linux/Pkgs/conf/distributions

     	looks good

linux/Pkgs/options

     >>add linux/Pkgs/options

     	ok

linux/pkg-tools/mk-binary-repo

     >>add linux/pkg-tools/mk-binary-repo

     	I'm not sure I get the logic here.  If a repo already
     	exists, build a repo out of that repo?	It would seem
     	that is what the if statement is doing?

linux/pkg-tools/mk-mipsel-deb-rootfs

     you have socat in mk-source-repo, but you don't have socat
     in this file, but you should.

linux/pkg-tools/mk-source-repo

     looks good

