AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071003121738.6dee04ad@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C911C@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 3 Oct 2007 12:17:55 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Review Request
Message-ID: <20071003121755.65395b19@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C911C@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C911C@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Haste makes mistakes.

linux/rootfs/Makefile

     sh!t, i thought we added the exim4 config file a long time ago

     we should generate a reasonable fstab file.  i thought we did
     that as part of the temporary rc script that you had?  we can
     still keep the fstab.sav code.

     line 134 and 139: I'm quite guilty of doing this "[ -x whatever
     ] || code" syntax, but i've decided that it's a maintenance
     liability, and i've now switched to using the much more readable
     and therefore maintainable "if [ ! -x whatever ] ; then code fi".
     In this case it would be:

     if [ ! -d $(@D) ] ; then mkdir $(@D) ; fi

     but seeing as how you do this a million times in this file,
     take that comment as something for the future ~:^)



linux/rootfs/etc/hosts

     >>add linux/rootfs/etc/hosts
     	not good.  please make this file easily editable by
     	sed from one of your scripts or makefiles, or easily
     	appendable to.	we can't ship it looking like this
        nor leaving it like this.  initial config must populate
     	the rest of this file, and if the host name or ip address
	is ever changed, this file must be modified by that config
        change. i assume that is already handled by nfxsh or whatever.
        but maybe that's why it's missing: it was probably handled by
        the now gone initial config?  or did they add the initial
        config back?




On Wed, 3 Oct 2007 11:35:56 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy could you please review this change list.
> 
> If you can't get to it any time soon, let me know and I will ask
> someone else. I would like to get this checked in ASAP>
> 
> Thanks,
> 
> Larry
> 
> P4 workspace: ~larrys/src/dev
> 
> Change 25715 by larrys@larrys on 2007/10/03 06:24:37 *pending*
> 
>         Updates to add EMRS certificates for SSL. 
>         Kernel target updated to call kernel_install this is needed to
> match
>         changes to linux/kernel/Makefile.
>         Adding a default etc/hosts file. The basic system
> configuration done by debootstrap can't be trusted to provide this
> file. If a user adds etc/fstab.sav to the etc directory use that file
>         to replace the system's default (typically empty) fstab.
>         This is a convenience for NFS ROOT users.
>         Reviewed by: AndyS
> 
> Affected files ...
> 
> ... //depot/dev/linux/rootfs/Makefile#4 edit
> ... //depot/dev/linux/rootfs/etc/hosts#1 add
