AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071003132304.3a3158e8@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C911D@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 3 Oct 2007 13:23:47 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Review Request
Message-ID: <20071003132347.295b5b3a@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C911D@onstor-exch02.onstor.net>
References: <20071003121755.65395b19@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C911D@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 3 Oct 2007 12:59:48 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> My comments in-line
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, October 03, 2007 12:18 PM
> To: Larry Scheer
> Subject: Re: Review Request
> 
> Haste makes mistakes.
> 
> linux/rootfs/Makefile
> 
>      sh!t, i thought we added the exim4 config file a long time ago
> >> Not really. The exim4 config file was only just a week or so ago.
> >> I added it to this Makefile as soon as it was ready but the
> >> submittal
> got held up by other changes.
> 
>      we should generate a reasonable fstab file.  i thought we did
>      that as part of the temporary rc script that you had?  we can
>      still keep the fstab.sav code.
> 
> >> I agree. That will come later when the compact flash is available.
> >> We
> will need to handle the case where the compact flashes are swapped
> manually and need to modify the rc scripts to check and replace the
> fstab like we do with bsd. Or do you have another idea?

Well, I don't see why we don't generate a reasonable fstab file right
now, CF or NFS or whatever.  Makes no difference.  But the part about
el-swaperuney with the fstab file because of one CF card v. another
being primary, we won't do that in Linux: we will do something more
sophisticated that makes the CF card we are booted from always look
like the first disk device, eliminating who schools of bugs (and
adding other whole schools of bugs).  We won't need any of those ugly
scripts to fix up our crap. We'll have a pretty script to fix up our
crap.

>      line 134 and 139: I'm quite guilty of doing this "[ -x whatever
>      ] || code" syntax, but i've decided that it's a maintenance
>      liability, and i've now switched to using the much more readable
>      and therefore maintainable "if [ ! -x whatever ] ; then code fi".
>      In this case it would be:
> 
>      if [ ! -d $(@D) ] ; then mkdir $(@D) ; fi
> >> This (above) was the only way I wrote Makefiles until I got here.
> Since it was all over the place I started duplicating it. I figured
> since it was used liberally throughout Makefiles at ONStor most
> developers here understood the logic. Given it is handy and (perhaps)
> safe for use with cd and mkdir -p that is where I use it the most. 
> 
>      but seeing as how you do this a million times in this file,
>      take that comment as something for the future ~:^)
> 
> >> Okay, I won't change it.
> 
> 
> 
> linux/rootfs/etc/hosts
> 
>      >>add linux/rootfs/etc/hosts
>      	not good.  please make this file easily editable by
>      	sed from one of your scripts or makefiles, or easily
>      	appendable to.	we can't ship it looking like this
>         nor leaving it like this.  initial config must populate
>      	the rest of this file, and if the host name or ip address
> 	is ever changed, this file must be modified by that config
>         change. i assume that is already handled by nfxsh or whatever.
>         but maybe that's why it's missing: it was probably handled by
>         the now gone initial config?  or did they add the initial
>         config back?
> 
> >> Not sure what it should look like right now. I am thinking of using
> something similar to what is used in BSD.

Er, not.

> A problem we have right now
> is the initial config in Linux is not creating/editing this file. Not
> sure what nfxsh does with it. I think it updates it when you add a
> VSVR IP address but I will need to look at the code.
> >> What do you think of the idea where this file is just:
> 127.0.0.1       localhost

good

> then let the programs that are supposed to update this file just
> append to it?

excellent

> Of course this means onstor/initial-config needs to be
> updated to append to the file. (Which it isn't doing currently.)

Hm, you have my permission to fix that and add it to this changelist
~:^)  Seriously.  Currently it takes that information and does
something with it, I can't believe it doesn't update /etc/hosts.  But I
do believe it puts it in some stupid files like /etc/myipaddress
or /etc/eth0.hostname or /etc/rc1.hostname or some stupid
@!!%^@#^@E!!@#$!^gaaahaaAAAAaaaa

That stupid legacy scheme made me lose it.  Sorry.

But that reminds me that both (if there are two) management IP addresses
should be added to /etc/hosts, obviously under different, but similar,
names.  And if there is only one, don't assume that it's eth0.  If you
know what I mean.

> On Wed, 3 Oct 2007 11:35:56 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > Andy could you please review this change list.
> > 
> > If you can't get to it any time soon, let me know and I will ask
> > someone else. I would like to get this checked in ASAP>
> > 
> > Thanks,
> > 
> > Larry
> > 
> > P4 workspace: ~larrys/src/dev
> > 
> > Change 25715 by larrys@larrys on 2007/10/03 06:24:37 *pending*
> > 
> >         Updates to add EMRS certificates for SSL. 
> >         Kernel target updated to call kernel_install this is needed
> > to match
> >         changes to linux/kernel/Makefile.
> >         Adding a default etc/hosts file. The basic system
> > configuration done by debootstrap can't be trusted to provide this
> > file. If a user adds etc/fstab.sav to the etc directory use that
> > file to replace the system's default (typically empty) fstab.
> >         This is a convenience for NFS ROOT users.
> >         Reviewed by: AndyS
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/rootfs/Makefile#4 edit
> > ... //depot/dev/linux/rootfs/etc/hosts#1 add
